From 9841d3fdf1f8eebb318a9e37a10ebc903d104782 Mon Sep 17 00:00:00 2001 From: Don Jayamanne Date: Wed, 27 Mar 2024 05:48:23 +1100 Subject: fix(kernel): Do not increase counter if store_history=false (#20848) Fixes https://github.com/denoland/deno/issues/20847 Co-authored-by: Nathan Whitaker --- tests/integration/jupyter_tests.rs | 28 ++++++++++++++++++++++++++++ 1 file changed, 28 insertions(+) (limited to 'tests') diff --git a/tests/integration/jupyter_tests.rs b/tests/integration/jupyter_tests.rs index 29636f305..02695c595 100644 --- a/tests/integration/jupyter_tests.rs +++ b/tests/integration/jupyter_tests.rs @@ -533,3 +533,31 @@ async fn jupyter_execute_request() -> Result<()> { Ok(()) } + +#[tokio::test] +async fn jupyter_store_history_false() -> Result<()> { + let (_ctx, client, _process) = setup().await; + client + .send( + Shell, + "execute_request", + json!({ + "silent": false, + "store_history": false, + "code": "console.log(\"asdf\")" + }), + ) + .await?; + + let reply = client.recv(Shell).await?; + assert_eq!(reply.header.msg_type, "execute_reply"); + assert_eq_subset( + reply.content, + json!({ + "status": "ok", + "execution_count": 0, + }), + ); + + Ok(()) +} -- cgit v1.2.3