From 8f32a1577ec00d239bce39dd1f526b5678041b8b Mon Sep 17 00:00:00 2001 From: carles escrig royo Date: Mon, 23 Sep 2024 11:19:59 +0200 Subject: fix(ext/web): don't ignore capture in EventTarget.removeEventListener (#25788) --- tests/unit/event_target_test.ts | 58 +++++++++++++++++++++++++++++++++++++++++ 1 file changed, 58 insertions(+) (limited to 'tests') diff --git a/tests/unit/event_target_test.ts b/tests/unit/event_target_test.ts index 3577587d1..3f7d8ee24 100644 --- a/tests/unit/event_target_test.ts +++ b/tests/unit/event_target_test.ts @@ -67,6 +67,64 @@ Deno.test(function anEventTargetCanBeSubclassed() { assertEquals(callCount, 0); }); +Deno.test(function removeEventListenerTest() { + const target = new EventTarget(); + let callCount = 0; + const listener = () => { + ++callCount; + }; + + target.addEventListener("incr", listener, true); + + target.dispatchEvent(new Event("incr")); + assertEquals(callCount, 1); + + // Should not remove the listener because useCapture does not match + target.removeEventListener("incr", listener, false); + + target.dispatchEvent(new Event("incr")); + assertEquals(callCount, 2); + + // Should remove the listener because useCapture matches + target.removeEventListener("incr", listener, true); + + target.dispatchEvent(new Event("incr")); + assertEquals(callCount, 2); + + // Only the capture setting matters to removeEventListener + target.addEventListener("incr", listener, { passive: true }); + + target.dispatchEvent(new Event("incr")); + assertEquals(callCount, 3); + + // Should not remove the listener because useCapture does not match + target.removeEventListener("incr", listener, { capture: true }); + target.removeEventListener("incr", listener, true); + + target.dispatchEvent(new Event("incr")); + assertEquals(callCount, 4); + + // Should remove the listener because useCapture matches + target.removeEventListener("incr", listener); + + target.dispatchEvent(new Event("incr")); + assertEquals(callCount, 4); + + // Again, should remove the listener because useCapture matches + target.addEventListener("incr", listener, { passive: true }); + target.removeEventListener("incr", listener, false); + + target.dispatchEvent(new Event("incr")); + assertEquals(callCount, 4); + + // Again, should remove the listener because useCapture matches + target.addEventListener("incr", listener, { passive: true }); + target.removeEventListener("incr", listener, { capture: false }); + + target.dispatchEvent(new Event("incr")); + assertEquals(callCount, 4); +}); + Deno.test(function removingNullEventListenerShouldSucceed() { const document = new EventTarget(); assertEquals(document.removeEventListener("x", null, false), undefined); -- cgit v1.2.3