From 7a41a939972b701e96cb70cbf0516595fefcae02 Mon Sep 17 00:00:00 2001 From: Luca Casonato Date: Wed, 18 Sep 2024 21:14:40 +0200 Subject: fix(ext/http): gracefully handle Response.error responses (#25712) Fixes #14371 --- tests/unit/serve_test.ts | 34 ++++++++++++++++++++++++++++++++++ 1 file changed, 34 insertions(+) (limited to 'tests') diff --git a/tests/unit/serve_test.ts b/tests/unit/serve_test.ts index c1e217a11..d417d8d26 100644 --- a/tests/unit/serve_test.ts +++ b/tests/unit/serve_test.ts @@ -678,6 +678,40 @@ Deno.test( }, ); +Deno.test( + { permissions: { net: true } }, + async function httpServerReturnErrorResponse() { + const ac = new AbortController(); + const { promise, resolve } = Promise.withResolvers(); + let hadError = false; + const server = Deno.serve({ + handler: () => { + return Response.error(); + }, + port: servePort, + signal: ac.signal, + onListen: onListen(resolve), + onError: () => { + hadError = true; + return new Response("Internal Server Error", { status: 500 }); + }, + }); + + await promise; + + const resp = await fetch(`http://127.0.0.1:${servePort}/`, { + headers: { "connection": "close" }, + }); + assertEquals(resp.status, 500); + const text = await resp.text(); + assertEquals(text, "Internal Server Error"); + assert(hadError); + + ac.abort(); + await server.finished; + }, +); + Deno.test({ permissions: { net: true } }, async function httpServerOverload1() { const ac = new AbortController(); const deferred = Promise.withResolvers(); -- cgit v1.2.3