From 779a98cd39b781091427e68b1548d4f3189a8595 Mon Sep 17 00:00:00 2001 From: Satya Rohith Date: Thu, 3 Oct 2024 21:56:55 +0530 Subject: tests: enable specs::run::package_json::invalid_value (#25826) Towards https://github.com/denoland/deno/issues/25241 Co-authored-by: David Sherret --- .../run/package_json/invalid_value/__test__.jsonc | 49 ++++++++++++++++++---- .../specs/run/package_json/invalid_value/error.out | 2 + .../run/package_json/invalid_value/error.ts.out | 5 --- .../run/package_json/invalid_value/error_auto.out | 8 ++++ .../run/package_json/invalid_value/install.out | 3 ++ .../specs/run/package_json/invalid_value/ok.ts.out | 3 -- .../specs/run/package_json/invalid_value/task.out | 3 -- 7 files changed, 53 insertions(+), 20 deletions(-) create mode 100644 tests/specs/run/package_json/invalid_value/error.out delete mode 100644 tests/specs/run/package_json/invalid_value/error.ts.out create mode 100644 tests/specs/run/package_json/invalid_value/error_auto.out create mode 100644 tests/specs/run/package_json/invalid_value/install.out (limited to 'tests') diff --git a/tests/specs/run/package_json/invalid_value/__test__.jsonc b/tests/specs/run/package_json/invalid_value/__test__.jsonc index 7f85713cb..0b3c63384 100644 --- a/tests/specs/run/package_json/invalid_value/__test__.jsonc +++ b/tests/specs/run/package_json/invalid_value/__test__.jsonc @@ -1,23 +1,54 @@ { "tempDir": true, - // TODO(2.0): update the tests, should probably run install first - "ignore": true, "tests": { // should run fine when not referencing a failing dep entry - "run_ok": { - "args": "run ok.ts", + "run_ok_auto": { + "args": "run --quiet --node-modules-dir=auto ok.ts", "output": "ok.ts.out" }, + "run_ok_byonm": { + "steps": [ + { + "args": "install", + "output": "install.out" + }, + { + "args": "run ok.ts", + "output": "ok.ts.out" + } + ] + }, // should fail when referencing a failing dep entry - "run_error": { - "args": "run error.ts", + "run_error_auto": { + "args": "run --node-modules-dir=auto error.ts", "exitCode": 1, - "output": "error.ts.out" + "output": "error_auto.out" + }, + "run_error_byonm": { + "steps": [ + { + "args": "install", + "output": "install.out" + }, + { + "args": "run error.ts", + "exitCode": 1, + "output": "error.out" + } + ] }, // should output a warning about the failing dep entry "task_test": { - "args": "task test", - "output": "task.out" + "steps": [ + { + "args": "install", + "output": "install.out" + }, + { + "args": "task test", + "output": "task.out" + } + ] } } } diff --git a/tests/specs/run/package_json/invalid_value/error.out b/tests/specs/run/package_json/invalid_value/error.out new file mode 100644 index 000000000..597535113 --- /dev/null +++ b/tests/specs/run/package_json/invalid_value/error.out @@ -0,0 +1,2 @@ +error: Could not resolve "@denotest/cjs-default-export", but found it in a package.json. Deno expects the node_modules/ directory to be up to date. Did you forget to run `deno install`? + at file:///[WILDCARD]/error.ts:2:23 diff --git a/tests/specs/run/package_json/invalid_value/error.ts.out b/tests/specs/run/package_json/invalid_value/error.ts.out deleted file mode 100644 index 37796d6da..000000000 --- a/tests/specs/run/package_json/invalid_value/error.ts.out +++ /dev/null @@ -1,5 +0,0 @@ -error: Invalid version requirement - 0: Unexpected character. - invalid stuff that won't parse - ~ - at file:///[WILDCARD]/error.ts:2:23 diff --git a/tests/specs/run/package_json/invalid_value/error_auto.out b/tests/specs/run/package_json/invalid_value/error_auto.out new file mode 100644 index 000000000..7641a4d86 --- /dev/null +++ b/tests/specs/run/package_json/invalid_value/error_auto.out @@ -0,0 +1,8 @@ +Download http://localhost:4260/@denotest/esm-basic +Download http://localhost:4260/@denotest/esm-basic/1.0.0.tgz +Initialize @denotest/esm-basic@1.0.0 +error: Invalid version requirement + 0: Unexpected character. + invalid stuff that won't parse + ~ + at file:///[WILDCARD]/error.ts:2:23 diff --git a/tests/specs/run/package_json/invalid_value/install.out b/tests/specs/run/package_json/invalid_value/install.out new file mode 100644 index 000000000..b8114c12a --- /dev/null +++ b/tests/specs/run/package_json/invalid_value/install.out @@ -0,0 +1,3 @@ +Download http://localhost:4260/@denotest/esm-basic +Download http://localhost:4260/@denotest/esm-basic/1.0.0.tgz +Initialize @denotest/esm-basic@1.0.0 diff --git a/tests/specs/run/package_json/invalid_value/ok.ts.out b/tests/specs/run/package_json/invalid_value/ok.ts.out index e8fff7ed7..0cfbf0888 100644 --- a/tests/specs/run/package_json/invalid_value/ok.ts.out +++ b/tests/specs/run/package_json/invalid_value/ok.ts.out @@ -1,4 +1 @@ -Download http://localhost:4260/@denotest/esm-basic -Download http://localhost:4260/@denotest/esm-basic/1.0.0.tgz -Initialize @denotest/esm-basic@1.0.0 2 diff --git a/tests/specs/run/package_json/invalid_value/task.out b/tests/specs/run/package_json/invalid_value/task.out index d0adb0525..79249d175 100644 --- a/tests/specs/run/package_json/invalid_value/task.out +++ b/tests/specs/run/package_json/invalid_value/task.out @@ -1,5 +1,2 @@ -Download http://localhost:4260/@denotest/esm-basic -Download http://localhost:4260/@denotest/esm-basic/1.0.0.tgz -Initialize @denotest/esm-basic@1.0.0 Task test echo 1 1 -- cgit v1.2.3