From 736f73b008c3f0354b870b70b8d494983046b0f7 Mon Sep 17 00:00:00 2001 From: Nathan Whitaker <17734409+nathanwhit@users.noreply.github.com> Date: Wed, 10 Apr 2024 18:06:37 -0700 Subject: perf(lsp): Only evict caches on JS side when things actually change (#23293) Currently we evict a lot of the caches on the JS side of things on every request, namely script versions, script file names, and compiler settings (as of #23283, it's not quite every request but it's still unnecessarily often). This PR reports changes to the JS side, so that it can evict exactly the caches that it needs too. We might want to do some batching in the future so as not to do 1 request per change. --- tests/integration/lsp_tests.rs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'tests') diff --git a/tests/integration/lsp_tests.rs b/tests/integration/lsp_tests.rs index 92a53a8b2..a3d2cf57e 100644 --- a/tests/integration/lsp_tests.rs +++ b/tests/integration/lsp_tests.rs @@ -9044,15 +9044,15 @@ fn lsp_performance() { "tsc.host.$getAssets", "tsc.host.$getDiagnostics", "tsc.host.$getSupportedCodeFixes", + "tsc.host.$projectChanged", "tsc.host.getQuickInfoAtPosition", "tsc.op.op_is_node_file", "tsc.op.op_load", - "tsc.op.op_project_version", "tsc.op.op_script_names", - "tsc.op.op_script_version", "tsc.op.op_ts_config", "tsc.request.$getAssets", "tsc.request.$getSupportedCodeFixes", + "tsc.request.$projectChanged", "tsc.request.getQuickInfoAtPosition", ] ); -- cgit v1.2.3