From 6f0fbceaf213f523bc68d23ea28fd457499f3a75 Mon Sep 17 00:00:00 2001
From: Luca Casonato <hello@lcas.dev>
Date: Fri, 27 Sep 2024 16:14:17 +0200
Subject: fix(lint): correctly handle old jsx in linter (#25902)

Previously the CLI was incorrectly reporting `React` as unused in a JSX
file that uses the "old" transform.

The LSP was already handling this correctly.
---
 tests/specs/lint/jsx/__test__.jsonc      | 14 +++++++-------
 tests/specs/lint/jsx/main.jsx            |  1 -
 tests/specs/lint/jsx/main_unix.out       | 12 ------------
 tests/specs/lint/jsx/main_windows.out    | 12 ------------
 tests/specs/lint/jsx/react-jsx.out       | 12 ++++++++++++
 tests/specs/lint/jsx/react-jsx/deno.json |  5 +++++
 tests/specs/lint/jsx/react-jsx/mod.tsx   |  3 +++
 tests/specs/lint/jsx/react.out           |  1 +
 tests/specs/lint/jsx/react/deno.json     |  1 +
 tests/specs/lint/jsx/react/mod.tsx       |  3 +++
 10 files changed, 32 insertions(+), 32 deletions(-)
 delete mode 100644 tests/specs/lint/jsx/main.jsx
 delete mode 100644 tests/specs/lint/jsx/main_unix.out
 delete mode 100644 tests/specs/lint/jsx/main_windows.out
 create mode 100644 tests/specs/lint/jsx/react-jsx.out
 create mode 100644 tests/specs/lint/jsx/react-jsx/deno.json
 create mode 100644 tests/specs/lint/jsx/react-jsx/mod.tsx
 create mode 100644 tests/specs/lint/jsx/react.out
 create mode 100644 tests/specs/lint/jsx/react/deno.json
 create mode 100644 tests/specs/lint/jsx/react/mod.tsx

(limited to 'tests')

diff --git a/tests/specs/lint/jsx/__test__.jsonc b/tests/specs/lint/jsx/__test__.jsonc
index 42dda30a5..b929e12d4 100644
--- a/tests/specs/lint/jsx/__test__.jsonc
+++ b/tests/specs/lint/jsx/__test__.jsonc
@@ -1,15 +1,15 @@
 {
   "steps": [
     {
-      "if": "windows",
-      "args": "lint main.jsx",
-      "output": "main_windows.out",
-      "exitCode": 1
+      "args": "lint",
+      "cwd": "./react",
+      "output": "react.out",
+      "exitCode": 0
     },
     {
-      "if": "unix",
-      "args": "lint main.jsx",
-      "output": "main_unix.out",
+      "args": "lint",
+      "cwd": "./react-jsx",
+      "output": "react-jsx.out",
       "exitCode": 1
     }
   ]
diff --git a/tests/specs/lint/jsx/main.jsx b/tests/specs/lint/jsx/main.jsx
deleted file mode 100644
index 625e7d430..000000000
--- a/tests/specs/lint/jsx/main.jsx
+++ /dev/null
@@ -1 +0,0 @@
-const data = <div>hello</div>;
diff --git a/tests/specs/lint/jsx/main_unix.out b/tests/specs/lint/jsx/main_unix.out
deleted file mode 100644
index 08816e9fe..000000000
--- a/tests/specs/lint/jsx/main_unix.out
+++ /dev/null
@@ -1,12 +0,0 @@
-error[no-unused-vars]: `data` is never used
- --> [WILDCARD]lint/jsx/main.jsx:1:7
-  | 
-1 | const data = <div>hello</div>;
-  |       ^^^^
-  = hint: If this is intentional, prefix it with an underscore like `_data`
-
-  docs: https://lint.deno.land/rules/no-unused-vars
-
-
-Found 1 problem
-Checked 1 file
diff --git a/tests/specs/lint/jsx/main_windows.out b/tests/specs/lint/jsx/main_windows.out
deleted file mode 100644
index ec6ebecad..000000000
--- a/tests/specs/lint/jsx/main_windows.out
+++ /dev/null
@@ -1,12 +0,0 @@
-error[no-unused-vars]: `data` is never used
- --> [WILDCARD]lint\jsx\main.jsx:1:7
-  | 
-1 | const data = <div>hello</div>;
-  |       ^^^^
-  = hint: If this is intentional, prefix it with an underscore like `_data`
-
-  docs: https://lint.deno.land/rules/no-unused-vars
-
-
-Found 1 problem
-Checked 1 file
diff --git a/tests/specs/lint/jsx/react-jsx.out b/tests/specs/lint/jsx/react-jsx.out
new file mode 100644
index 000000000..c8c700779
--- /dev/null
+++ b/tests/specs/lint/jsx/react-jsx.out
@@ -0,0 +1,12 @@
+error[no-unused-vars]: `React` is never used
+ --> [WILDCARD]mod.tsx:1:7
+  | 
+1 | const React = { createElement() {} };
+  |       ^^^^^
+  = hint: If this is intentional, prefix it with an underscore like `_React`
+
+  docs: https://lint.deno.land/rules/no-unused-vars
+
+
+Found 1 problem
+Checked 1 file
diff --git a/tests/specs/lint/jsx/react-jsx/deno.json b/tests/specs/lint/jsx/react-jsx/deno.json
new file mode 100644
index 000000000..a224293f4
--- /dev/null
+++ b/tests/specs/lint/jsx/react-jsx/deno.json
@@ -0,0 +1,5 @@
+{
+  "compilerOptions": {
+    "jsx": "react-jsx"
+  }
+}
diff --git a/tests/specs/lint/jsx/react-jsx/mod.tsx b/tests/specs/lint/jsx/react-jsx/mod.tsx
new file mode 100644
index 000000000..be1e843c1
--- /dev/null
+++ b/tests/specs/lint/jsx/react-jsx/mod.tsx
@@ -0,0 +1,3 @@
+const React = { createElement() {} };
+
+const _div = <div />;
diff --git a/tests/specs/lint/jsx/react.out b/tests/specs/lint/jsx/react.out
new file mode 100644
index 000000000..c05ac45a1
--- /dev/null
+++ b/tests/specs/lint/jsx/react.out
@@ -0,0 +1 @@
+Checked 1 file
diff --git a/tests/specs/lint/jsx/react/deno.json b/tests/specs/lint/jsx/react/deno.json
new file mode 100644
index 000000000..0967ef424
--- /dev/null
+++ b/tests/specs/lint/jsx/react/deno.json
@@ -0,0 +1 @@
+{}
diff --git a/tests/specs/lint/jsx/react/mod.tsx b/tests/specs/lint/jsx/react/mod.tsx
new file mode 100644
index 000000000..be1e843c1
--- /dev/null
+++ b/tests/specs/lint/jsx/react/mod.tsx
@@ -0,0 +1,3 @@
+const React = { createElement() {} };
+
+const _div = <div />;
-- 
cgit v1.2.3