From 5c40b47629bc83b9120019b77b34ced5eaabcffe Mon Sep 17 00:00:00 2001 From: Nathan Whitaker <17734409+nathanwhit@users.noreply.github.com> Date: Tue, 24 Sep 2024 18:10:01 -0700 Subject: fix(add/install): default to "latest" tag for npm packages in `deno add npm:pkg` (#25858) Fixes #25813. I initially tried doing this in `deno_semver`, where it's a cleaner change, but that caused breakage in deno in places where we don't expect a tag (see https://github.com/denoland/deno/issues/25857). This does not fix wildcard requirements failing to choose pre-release versions. That's a little more involved and I'll do a separate PR. --- tests/registry/npm/@denotest/unstable/1.0.0-beta.1/index.js | 3 +++ tests/registry/npm/@denotest/unstable/1.0.0-beta.1/package.json | 5 +++++ tests/specs/add/only_unstable_versions/__test__.jsonc | 9 +++++++++ tests/specs/add/only_unstable_versions/add.out | 3 +++ tests/specs/add/only_unstable_versions/deno.json | 1 + 5 files changed, 21 insertions(+) create mode 100644 tests/registry/npm/@denotest/unstable/1.0.0-beta.1/index.js create mode 100644 tests/registry/npm/@denotest/unstable/1.0.0-beta.1/package.json create mode 100644 tests/specs/add/only_unstable_versions/__test__.jsonc create mode 100644 tests/specs/add/only_unstable_versions/add.out create mode 100644 tests/specs/add/only_unstable_versions/deno.json (limited to 'tests') diff --git a/tests/registry/npm/@denotest/unstable/1.0.0-beta.1/index.js b/tests/registry/npm/@denotest/unstable/1.0.0-beta.1/index.js new file mode 100644 index 000000000..ba330abd5 --- /dev/null +++ b/tests/registry/npm/@denotest/unstable/1.0.0-beta.1/index.js @@ -0,0 +1,3 @@ +export function sayHello() { + console.log("Hello") +} \ No newline at end of file diff --git a/tests/registry/npm/@denotest/unstable/1.0.0-beta.1/package.json b/tests/registry/npm/@denotest/unstable/1.0.0-beta.1/package.json new file mode 100644 index 000000000..69f2a57cd --- /dev/null +++ b/tests/registry/npm/@denotest/unstable/1.0.0-beta.1/package.json @@ -0,0 +1,5 @@ +{ + "name": "@denotest/unstable", + "type": "module", + "version": "1.0.0-beta.1" +} \ No newline at end of file diff --git a/tests/specs/add/only_unstable_versions/__test__.jsonc b/tests/specs/add/only_unstable_versions/__test__.jsonc new file mode 100644 index 000000000..d05628b6f --- /dev/null +++ b/tests/specs/add/only_unstable_versions/__test__.jsonc @@ -0,0 +1,9 @@ +{ + "tempDir": true, + "steps": [ + { + "args": "add npm:@denotest/unstable", + "output": "add.out" + } + ] +} diff --git a/tests/specs/add/only_unstable_versions/add.out b/tests/specs/add/only_unstable_versions/add.out new file mode 100644 index 000000000..48462b8be --- /dev/null +++ b/tests/specs/add/only_unstable_versions/add.out @@ -0,0 +1,3 @@ +Add npm:@denotest/unstable@1.0.0-beta.1 +Download http://localhost:4260/@denotest/unstable +Download http://localhost:4260/@denotest/unstable/1.0.0-beta.1.tgz diff --git a/tests/specs/add/only_unstable_versions/deno.json b/tests/specs/add/only_unstable_versions/deno.json new file mode 100644 index 000000000..0967ef424 --- /dev/null +++ b/tests/specs/add/only_unstable_versions/deno.json @@ -0,0 +1 @@ +{} -- cgit v1.2.3