From 4f49f703c10afcde7155baac2b494fa6670c0115 Mon Sep 17 00:00:00 2001 From: Yazan AbdAl-Rahman Date: Tue, 20 Aug 2024 04:20:06 +0300 Subject: fix(cli): update permission prompt message for compiled binaries (#24081) Co-authored-by: David Sherret --- .../compile/permissions_denied/__test__.jsonc | 24 ++++++++++++++++++++++ tests/specs/compile/permissions_denied/main.out | 2 ++ tests/specs/compile/permissions_denied/main.ts | 1 + .../npm/deno_run_cowsay_no_permissions.out | 2 +- 4 files changed, 28 insertions(+), 1 deletion(-) create mode 100644 tests/specs/compile/permissions_denied/__test__.jsonc create mode 100644 tests/specs/compile/permissions_denied/main.out create mode 100644 tests/specs/compile/permissions_denied/main.ts (limited to 'tests') diff --git a/tests/specs/compile/permissions_denied/__test__.jsonc b/tests/specs/compile/permissions_denied/__test__.jsonc new file mode 100644 index 000000000..8f8590162 --- /dev/null +++ b/tests/specs/compile/permissions_denied/__test__.jsonc @@ -0,0 +1,24 @@ +{ + "tempDir": true, + "steps": [{ + "if": "unix", + "args": "compile --output main main.ts", + "output": "[WILDCARD]" + }, { + "if": "unix", + "commandName": "./main", + "args": [], + "exitCode": 1, + "output": "main.out" + }, { + "if": "windows", + "args": "compile --output main.exe main.ts", + "output": "[WILDCARD]" + }, { + "if": "windows", + "commandName": "./main.exe", + "args": [], + "exitCode": 1, + "output": "main.out" + }] +} diff --git a/tests/specs/compile/permissions_denied/main.out b/tests/specs/compile/permissions_denied/main.out new file mode 100644 index 000000000..e9ea45c81 --- /dev/null +++ b/tests/specs/compile/permissions_denied/main.out @@ -0,0 +1,2 @@ +error: Uncaught (in promise) PermissionDenied: Requires run access to "deno", specify the required permissions during compilation using `deno compile --allow-run` +[WILDCARD] \ No newline at end of file diff --git a/tests/specs/compile/permissions_denied/main.ts b/tests/specs/compile/permissions_denied/main.ts new file mode 100644 index 000000000..eeac858ff --- /dev/null +++ b/tests/specs/compile/permissions_denied/main.ts @@ -0,0 +1 @@ +new Deno.Command("deno").outputSync(); diff --git a/tests/testdata/npm/deno_run_cowsay_no_permissions.out b/tests/testdata/npm/deno_run_cowsay_no_permissions.out index 206ef1484..837394d49 100644 --- a/tests/testdata/npm/deno_run_cowsay_no_permissions.out +++ b/tests/testdata/npm/deno_run_cowsay_no_permissions.out @@ -1,2 +1,2 @@ -error: Uncaught PermissionDenied: Requires read access to , run again with the --allow-read flag +error: Uncaught PermissionDenied: Requires read access to , specify the required permissions during compilation using `deno compile --allow-read` [WILDCARD] -- cgit v1.2.3