From 2f5a6a8514ad8eadce1a0a9f1a7a419692e337ef Mon Sep 17 00:00:00 2001 From: Asher Gomez Date: Sun, 21 Apr 2024 13:03:44 +1000 Subject: FUTURE(ext/net): remove `Deno.ConnectTlsOptions.(certFile|certChain|privateKey)` (#23270) Towards #23089 --------- Signed-off-by: Asher Gomez --- tests/specs/future/runtime_api/main.js | 23 ++++++++++++++++++++++- tests/specs/future/runtime_api/main.out | 2 ++ 2 files changed, 24 insertions(+), 1 deletion(-) (limited to 'tests') diff --git a/tests/specs/future/runtime_api/main.js b/tests/specs/future/runtime_api/main.js index b44291218..eac8ed194 100644 --- a/tests/specs/future/runtime_api/main.js +++ b/tests/specs/future/runtime_api/main.js @@ -74,7 +74,6 @@ const tlsConn = await Deno.connectTls({ port: tlsPort }); console.log("Deno.TlsConn.prototype.rid is", tlsConn.rid); tlsConn.close(); -tlsListener.close(); const watcher = Deno.watchFs("."); console.log("Deno.FsWatcher.prototype.rid is", watcher.rid); @@ -92,6 +91,28 @@ try { } } +// Note: this could throw with a `Deno.errors.NotFound` error if `keyFile` and +// `certFile` were used. +const conn1 = await Deno.connectTls({ + port: tlsPort, + certFile: "foo", + keyFile: "foo", +}); +conn1.close(); +console.log("Deno.ConnectTlsOptions.(certFile|keyFile) do nothing"); + +// Note: this could throw with a `Deno.errors.InvalidData` error if `certChain` +// and `privateKey` were used. +const conn2 = await Deno.connectTls({ + port: tlsPort, + certChain: "foo", + privateKey: "foo", +}); +conn2.close(); +console.log("Deno.ConnectTlsOptions.(certChain|privateKey) do nothing"); + +tlsListener.close(); + // Note: this could throw with a `Deno.errors.NotFound` error if `keyFile` and // `certFile` were used. try { diff --git a/tests/specs/future/runtime_api/main.out b/tests/specs/future/runtime_api/main.out index 07b588495..4712a06b0 100644 --- a/tests/specs/future/runtime_api/main.out +++ b/tests/specs/future/runtime_api/main.out @@ -34,5 +34,7 @@ Deno.TlsListener.prototype.rid is undefined Deno.TlsConn.prototype.rid is undefined Deno.FsWatcher.prototype.rid is undefined Deno.FsFile constructor is illegal +Deno.ConnectTlsOptions.(certFile|keyFile) do nothing +Deno.ConnectTlsOptions.(certChain|privateKey) do nothing Deno.ListenTlsOptions.(keyFile|certFile) do nothing Deno.customInspect is undefined -- cgit v1.2.3