From 07ad47da53d1fbabf6fc5d26c89dc6ba683d27fd Mon Sep 17 00:00:00 2001 From: David Sherret Date: Wed, 4 Sep 2024 17:39:30 +0200 Subject: BREAKING(config): make supported compilerOptions an allow list (#25432) Deno has been using a deny list, which doesn't make sense because a lot of these options don't even work. Closes #25363 --- tests/integration/run_tests.rs | 5 ----- tests/testdata/run/checkjs.tsconfig.json | 1 - tests/testdata/run/decorators/experimental/ts/main.out | 1 + tests/testdata/run/no_check_imports_not_used_as_values/hello.ts | 2 -- tests/testdata/run/no_check_imports_not_used_as_values/main.out | 2 -- tests/testdata/run/no_check_imports_not_used_as_values/main.ts | 4 ---- .../preserve_imports.tsconfig.json | 5 ----- 7 files changed, 1 insertion(+), 19 deletions(-) delete mode 100644 tests/testdata/run/no_check_imports_not_used_as_values/hello.ts delete mode 100644 tests/testdata/run/no_check_imports_not_used_as_values/main.out delete mode 100644 tests/testdata/run/no_check_imports_not_used_as_values/main.ts delete mode 100644 tests/testdata/run/no_check_imports_not_used_as_values/preserve_imports.tsconfig.json (limited to 'tests') diff --git a/tests/integration/run_tests.rs b/tests/integration/run_tests.rs index 47fcdb657..117e5709e 100644 --- a/tests/integration/run_tests.rs +++ b/tests/integration/run_tests.rs @@ -483,11 +483,6 @@ itest!(dynamic_import_concurrent_non_statically_analyzable { http_server: true, }); -itest!(no_check_imports_not_used_as_values { - args: "run --config run/no_check_imports_not_used_as_values/preserve_imports.tsconfig.json --no-check run/no_check_imports_not_used_as_values/main.ts", - output: "run/no_check_imports_not_used_as_values/main.out", - }); - itest!(_088_dynamic_import_already_evaluating { args: "run --allow-read run/088_dynamic_import_already_evaluating.ts", output: "run/088_dynamic_import_already_evaluating.ts.out", diff --git a/tests/testdata/run/checkjs.tsconfig.json b/tests/testdata/run/checkjs.tsconfig.json index 46d96db9e..08ac60b6c 100644 --- a/tests/testdata/run/checkjs.tsconfig.json +++ b/tests/testdata/run/checkjs.tsconfig.json @@ -1,6 +1,5 @@ { "compilerOptions": { - "allowJs": true, "checkJs": true } } diff --git a/tests/testdata/run/decorators/experimental/ts/main.out b/tests/testdata/run/decorators/experimental/ts/main.out index ee77417cf..ea64fbaa6 100644 --- a/tests/testdata/run/decorators/experimental/ts/main.out +++ b/tests/testdata/run/decorators/experimental/ts/main.out @@ -1,2 +1,3 @@ +Warning experimentalDecorators compiler option is deprecated and may be removed at any time Check [WILDCARD] SomeClass { someField: "asdf" } diff --git a/tests/testdata/run/no_check_imports_not_used_as_values/hello.ts b/tests/testdata/run/no_check_imports_not_used_as_values/hello.ts deleted file mode 100644 index 1a9d8f114..000000000 --- a/tests/testdata/run/no_check_imports_not_used_as_values/hello.ts +++ /dev/null @@ -1,2 +0,0 @@ -export type SomeType = unknown; -console.log("Hello, world!"); diff --git a/tests/testdata/run/no_check_imports_not_used_as_values/main.out b/tests/testdata/run/no_check_imports_not_used_as_values/main.out deleted file mode 100644 index f744c4183..000000000 --- a/tests/testdata/run/no_check_imports_not_used_as_values/main.out +++ /dev/null @@ -1,2 +0,0 @@ -[WILDCARD]Hello, world! -Hi! diff --git a/tests/testdata/run/no_check_imports_not_used_as_values/main.ts b/tests/testdata/run/no_check_imports_not_used_as_values/main.ts deleted file mode 100644 index 80e17aa35..000000000 --- a/tests/testdata/run/no_check_imports_not_used_as_values/main.ts +++ /dev/null @@ -1,4 +0,0 @@ -import { SomeType } from "./hello.ts"; - -const string: SomeType = "Hi!"; -console.log(string); diff --git a/tests/testdata/run/no_check_imports_not_used_as_values/preserve_imports.tsconfig.json b/tests/testdata/run/no_check_imports_not_used_as_values/preserve_imports.tsconfig.json deleted file mode 100644 index 9b19291aa..000000000 --- a/tests/testdata/run/no_check_imports_not_used_as_values/preserve_imports.tsconfig.json +++ /dev/null @@ -1,5 +0,0 @@ -{ - "compilerOptions": { - "importsNotUsedAsValues": "preserve" - } -} -- cgit v1.2.3