From 74fc66da110ec20d12751e7a0922cea300314399 Mon Sep 17 00:00:00 2001 From: David Sherret Date: Wed, 4 Sep 2024 14:51:24 +0200 Subject: fix: lock down allow-run permissions more (#25370) `--allow-run` even with an allow list has essentially been `--allow-all`... this locks it down more. 1. Resolves allow list for `--allow-run=` on startup to an absolute path, then uses these paths when evaluating if a command can execute. Also, adds these paths to `--deny-write` 1. Resolves the environment (cwd and env vars) before evaluating permissions and before executing a command. Then uses this environment to evaluate the permissions and then evaluate the command. --- tests/unit/process_test.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'tests/unit') diff --git a/tests/unit/process_test.ts b/tests/unit/process_test.ts index a35362d09..383f17f38 100644 --- a/tests/unit/process_test.ts +++ b/tests/unit/process_test.ts @@ -611,6 +611,6 @@ Deno.test( p.close(); p.stdout.close(); assertStrictEquals(code, 1); - assertStringIncludes(stderr, "Failed getting cwd."); + assertStringIncludes(stderr, "failed resolving cwd:"); }, ); -- cgit v1.2.3