From 76b8ecbb6d8c07d29c34fb0b301cc3bf3351e3aa Mon Sep 17 00:00:00 2001 From: Yoshiya Hinosawa Date: Fri, 19 Jul 2024 12:37:08 +0900 Subject: fix(ext/node): do not expose `self` global in node (#24637) closes #23727 --- tests/testdata/npm/compare_globals/main.out | 4 ++++ tests/testdata/npm/compare_globals/main.ts | 7 ++++++- 2 files changed, 10 insertions(+), 1 deletion(-) (limited to 'tests/testdata') diff --git a/tests/testdata/npm/compare_globals/main.out b/tests/testdata/npm/compare_globals/main.out index 5af536657..9c9c2203a 100644 --- a/tests/testdata/npm/compare_globals/main.out +++ b/tests/testdata/npm/compare_globals/main.out @@ -21,6 +21,10 @@ true true true true +true +true +false +false false false bar diff --git a/tests/testdata/npm/compare_globals/main.ts b/tests/testdata/npm/compare_globals/main.ts index 6f7b9ef8e..5d082386f 100644 --- a/tests/testdata/npm/compare_globals/main.ts +++ b/tests/testdata/npm/compare_globals/main.ts @@ -37,12 +37,17 @@ console.log( ); globals.checkProcessGlobal(); -// In Deno, the window global is defined, but in Node it is not. +// In Deno, the window and self globals are defined, but in Node they are not. console.log("window" in globalThis); +console.log("self" in globalThis); console.log( Object.getOwnPropertyDescriptor(globalThis, "window") !== undefined, ); +console.log( + Object.getOwnPropertyDescriptor(globalThis, "self") !== undefined, +); globals.checkWindowGlobal(); +globals.checkSelfGlobal(); // "Non-managed" globals are shared between Node and Deno. (globalThis as any).foo = "bar"; -- cgit v1.2.3