From 86bc7a43810846fc66bf06b7577490f01ead1918 Mon Sep 17 00:00:00 2001 From: Satya Rohith Date: Wed, 3 Apr 2024 16:42:16 +0530 Subject: fix(ext/node): patch MessagePort if provided as workerData (#23198) MessagePort if directly assigned to workerData property instead of embedding it in an object then it is not patched to a NodeMessagePort. This commit fixes the bug. --- tests/testdata/workers/node_worker_message_port.mjs | 2 +- tests/testdata/workers/node_worker_message_port_1.cjs | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) (limited to 'tests/testdata/workers') diff --git a/tests/testdata/workers/node_worker_message_port.mjs b/tests/testdata/workers/node_worker_message_port.mjs index 71640fb40..91c7e062d 100644 --- a/tests/testdata/workers/node_worker_message_port.mjs +++ b/tests/testdata/workers/node_worker_message_port.mjs @@ -9,7 +9,7 @@ const deferred = createDeferred(); const worker = new workerThreads.Worker( import.meta.resolve("./node_worker_message_port_1.cjs"), { - workerData: { workerPort }, + workerData: workerPort, transferList: [workerPort], }, ); diff --git a/tests/testdata/workers/node_worker_message_port_1.cjs b/tests/testdata/workers/node_worker_message_port_1.cjs index 01739c51e..3f78cd539 100644 --- a/tests/testdata/workers/node_worker_message_port_1.cjs +++ b/tests/testdata/workers/node_worker_message_port_1.cjs @@ -1,7 +1,7 @@ const { parentPort, workerData } = require("worker_threads"); parentPort.on("message", (msg) => { - const workerPort = workerData.workerPort; + const workerPort = workerData; parentPort.postMessage("Hello from worker on parentPort!"); workerPort.postMessage("Hello from worker on workerPort!"); workerPort.on("close", () => console.log("worker port closed")); -- cgit v1.2.3