From 9be8dce0c7f8deaeff5523735e0867194ec04c59 Mon Sep 17 00:00:00 2001 From: Nathan Whitaker <17734409+nathanwhit@users.noreply.github.com> Date: Sat, 21 Sep 2024 16:10:38 -0700 Subject: fix(node): Include "node" condition during CJS re-export analysis (#25785) Fixes #25777. We were missing the "node" condition, so we were resolving to the wrong conditional export, causing our analysis to be incorrect. --- tests/specs/node/cjs_reexport_node_condition/__test__.jsonc | 13 +++++++++++++ tests/specs/node/cjs_reexport_node_condition/deno.json | 3 +++ tests/specs/node/cjs_reexport_node_condition/main.ts | 3 +++ tests/specs/node/cjs_reexport_node_condition/package.json | 5 +++++ 4 files changed, 24 insertions(+) create mode 100644 tests/specs/node/cjs_reexport_node_condition/__test__.jsonc create mode 100644 tests/specs/node/cjs_reexport_node_condition/deno.json create mode 100644 tests/specs/node/cjs_reexport_node_condition/main.ts create mode 100644 tests/specs/node/cjs_reexport_node_condition/package.json (limited to 'tests/specs') diff --git a/tests/specs/node/cjs_reexport_node_condition/__test__.jsonc b/tests/specs/node/cjs_reexport_node_condition/__test__.jsonc new file mode 100644 index 000000000..030f2aa07 --- /dev/null +++ b/tests/specs/node/cjs_reexport_node_condition/__test__.jsonc @@ -0,0 +1,13 @@ +{ + "tempDir": true, + "steps": [ + { + "args": "install", + "output": "[WILDCARD]" + }, + { + "args": "run -A ./main.ts", + "output": "from node\n" + } + ] +} diff --git a/tests/specs/node/cjs_reexport_node_condition/deno.json b/tests/specs/node/cjs_reexport_node_condition/deno.json new file mode 100644 index 000000000..fde86a1ef --- /dev/null +++ b/tests/specs/node/cjs_reexport_node_condition/deno.json @@ -0,0 +1,3 @@ +{ + "nodeModulesDir": "manual" +} diff --git a/tests/specs/node/cjs_reexport_node_condition/main.ts b/tests/specs/node/cjs_reexport_node_condition/main.ts new file mode 100644 index 000000000..09b8418a6 --- /dev/null +++ b/tests/specs/node/cjs_reexport_node_condition/main.ts @@ -0,0 +1,3 @@ +import { hello } from "@denotest/mjs-reexport-cjs"; + +console.log(hello); diff --git a/tests/specs/node/cjs_reexport_node_condition/package.json b/tests/specs/node/cjs_reexport_node_condition/package.json new file mode 100644 index 000000000..85ded5d50 --- /dev/null +++ b/tests/specs/node/cjs_reexport_node_condition/package.json @@ -0,0 +1,5 @@ +{ + "dependencies": { + "@denotest/mjs-reexport-cjs": "*" + } +} -- cgit v1.2.3