From 5cf97f539bb0c3d2bda918f53cd4a976c03b37e3 Mon Sep 17 00:00:00 2001 From: Luca Casonato Date: Tue, 3 Sep 2024 11:24:25 +0200 Subject: BREAKING(permissions): remove --allow-hrtime (#25367) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Remove `--allow-hrtime` and `--deny-hrtime`. We are doing this because it is already possible to get access to high resolution timers through workers and SharedArrayBuffer. Co-authored-by: Bartek Iwańczuk --- tests/specs/bench/allow_all/allow_all.out | 6 ++---- tests/specs/bench/allow_all/allow_all.ts | 1 - tests/specs/bench/allow_none/allow_none.out | 2 -- tests/specs/bench/allow_none/allow_none.ts | 1 - tests/specs/bench/ignore_permissions/ignore_permissions.ts | 1 - 5 files changed, 2 insertions(+), 9 deletions(-) (limited to 'tests/specs') diff --git a/tests/specs/bench/allow_all/allow_all.out b/tests/specs/bench/allow_all/allow_all.out index 4cc0f4204..b7d245de6 100644 --- a/tests/specs/bench/allow_all/allow_all.out +++ b/tests/specs/bench/allow_all/allow_all.out @@ -5,8 +5,8 @@ Runtime | Deno [WILDLINE] ([WILDLINE]) [WILDLINE]/allow_all.ts -benchmark time/iter (avg) iter/s (min … max) p75 p99 p995 --------------- ----------------------------- --------------------- -------------------------- +benchmark time/iter (avg) iter/s (min … max) p75 p99 p995 +------------- ----------------------------- --------------------- -------------------------- read false [WILDLINE] [WILDLINE] [WILDLINE] ([WILDLINE] … [WILDLINE]) [WILDLINE] read true [WILDLINE] [WILDLINE] [WILDLINE] ([WILDLINE] … [WILDLINE]) [WILDLINE] write false [WILDLINE] [WILDLINE] [WILDLINE] ([WILDLINE] … [WILDLINE]) [WILDLINE] @@ -19,6 +19,4 @@ run false [WILDLINE] [WILDLINE] [WILDLINE] ([WILDLINE] … [WILDLINE]) [WILDLINE run true [WILDLINE] [WILDLINE] [WILDLINE] ([WILDLINE] … [WILDLINE]) [WILDLINE] ffi false [WILDLINE] [WILDLINE] [WILDLINE] ([WILDLINE] … [WILDLINE]) [WILDLINE] ffi true [WILDLINE] [WILDLINE] [WILDLINE] ([WILDLINE] … [WILDLINE]) [WILDLINE] -hrtime false [WILDLINE] [WILDLINE] [WILDLINE] ([WILDLINE] … [WILDLINE]) [WILDLINE] -hrtime true [WILDLINE] [WILDLINE] [WILDLINE] ([WILDLINE] … [WILDLINE]) [WILDLINE] diff --git a/tests/specs/bench/allow_all/allow_all.ts b/tests/specs/bench/allow_all/allow_all.ts index 9747fb414..04dca8926 100644 --- a/tests/specs/bench/allow_all/allow_all.ts +++ b/tests/specs/bench/allow_all/allow_all.ts @@ -7,7 +7,6 @@ const permissions: Deno.PermissionName[] = [ "env", "run", "ffi", - "hrtime", ]; for (const name of permissions) { diff --git a/tests/specs/bench/allow_none/allow_none.out b/tests/specs/bench/allow_none/allow_none.out index 82bc7cc03..d92fb1469 100644 --- a/tests/specs/bench/allow_none/allow_none.out +++ b/tests/specs/bench/allow_none/allow_none.out @@ -18,6 +18,4 @@ run error: PermissionDenied: Can't escalate parent thread permissions [WILDCARD] ffi error: PermissionDenied: Can't escalate parent thread permissions [WILDCARD] -hrtime error: PermissionDenied: Can't escalate parent thread permissions -[WILDCARD] error: Bench failed diff --git a/tests/specs/bench/allow_none/allow_none.ts b/tests/specs/bench/allow_none/allow_none.ts index 77f86f256..59007ecb0 100644 --- a/tests/specs/bench/allow_none/allow_none.ts +++ b/tests/specs/bench/allow_none/allow_none.ts @@ -5,7 +5,6 @@ const permissions: Deno.PermissionName[] = [ "env", "run", "ffi", - "hrtime", ]; for (const name of permissions) { diff --git a/tests/specs/bench/ignore_permissions/ignore_permissions.ts b/tests/specs/bench/ignore_permissions/ignore_permissions.ts index 0dcd9299f..62f939015 100644 --- a/tests/specs/bench/ignore_permissions/ignore_permissions.ts +++ b/tests/specs/bench/ignore_permissions/ignore_permissions.ts @@ -7,7 +7,6 @@ Deno.bench({ env: true, run: true, ffi: true, - hrtime: true, }, ignore: true, fn() { -- cgit v1.2.3