From 43d10a558b72ef4a079358521d22447d095e0097 Mon Sep 17 00:00:00 2001 From: David Sherret Date: Tue, 9 Jul 2024 17:07:16 -0400 Subject: fix: do not download compilerOptions -> types when not type checking (#24473) Closes https://github.com/denoland/deno/issues/22738 --- tests/specs/run/skips_compiler_option_types/__test__.jsonc | 6 ++++++ tests/specs/run/skips_compiler_option_types/deno.json | 8 ++++++++ tests/specs/run/skips_compiler_option_types/main.out | 1 + tests/specs/run/skips_compiler_option_types/main.ts | 1 + 4 files changed, 16 insertions(+) create mode 100644 tests/specs/run/skips_compiler_option_types/__test__.jsonc create mode 100644 tests/specs/run/skips_compiler_option_types/deno.json create mode 100644 tests/specs/run/skips_compiler_option_types/main.out create mode 100644 tests/specs/run/skips_compiler_option_types/main.ts (limited to 'tests/specs') diff --git a/tests/specs/run/skips_compiler_option_types/__test__.jsonc b/tests/specs/run/skips_compiler_option_types/__test__.jsonc new file mode 100644 index 000000000..bd2d5aaa2 --- /dev/null +++ b/tests/specs/run/skips_compiler_option_types/__test__.jsonc @@ -0,0 +1,6 @@ +{ + // this was previously downloading the "types" from the compilerOptions + // even for deno run with no type checking + "args": "run main.ts", + "output": "main.out" +} diff --git a/tests/specs/run/skips_compiler_option_types/deno.json b/tests/specs/run/skips_compiler_option_types/deno.json new file mode 100644 index 000000000..92d0923b9 --- /dev/null +++ b/tests/specs/run/skips_compiler_option_types/deno.json @@ -0,0 +1,8 @@ +{ + "lock": false, + "compilerOptions": { + "types": [ + "https://localhost@4545/non-existent/@types/react@18.0.28" + ] + } +} diff --git a/tests/specs/run/skips_compiler_option_types/main.out b/tests/specs/run/skips_compiler_option_types/main.out new file mode 100644 index 000000000..45b983be3 --- /dev/null +++ b/tests/specs/run/skips_compiler_option_types/main.out @@ -0,0 +1 @@ +hi diff --git a/tests/specs/run/skips_compiler_option_types/main.ts b/tests/specs/run/skips_compiler_option_types/main.ts new file mode 100644 index 000000000..d914c6066 --- /dev/null +++ b/tests/specs/run/skips_compiler_option_types/main.ts @@ -0,0 +1 @@ +console.log("hi"); -- cgit v1.2.3