From b8a9a4a862e4d61630c5bc8089261c7a177ec97a Mon Sep 17 00:00:00 2001 From: David Sherret Date: Fri, 4 Oct 2024 08:16:35 +0100 Subject: Revert "feat: warn when using --allow-run with no allow list" (#26021) Although using `--allow-run` without an allow list gives basically no security, I think we should remove this warning because it gets in the way and the only way to disable it is via --quiet. --- tests/specs/run/allow_run_insecure_warnings/__test__.jsonc | 8 -------- tests/specs/run/allow_run_insecure_warnings/main.ts | 0 tests/specs/run/allow_run_insecure_warnings/no_allow_list.out | 1 - 3 files changed, 9 deletions(-) delete mode 100644 tests/specs/run/allow_run_insecure_warnings/__test__.jsonc delete mode 100644 tests/specs/run/allow_run_insecure_warnings/main.ts delete mode 100644 tests/specs/run/allow_run_insecure_warnings/no_allow_list.out (limited to 'tests/specs/run') diff --git a/tests/specs/run/allow_run_insecure_warnings/__test__.jsonc b/tests/specs/run/allow_run_insecure_warnings/__test__.jsonc deleted file mode 100644 index b64146ee9..000000000 --- a/tests/specs/run/allow_run_insecure_warnings/__test__.jsonc +++ /dev/null @@ -1,8 +0,0 @@ -{ - "tests": { - "no_allow_list": { - "args": "run --allow-run main.ts", - "output": "no_allow_list.out" - } - } -} diff --git a/tests/specs/run/allow_run_insecure_warnings/main.ts b/tests/specs/run/allow_run_insecure_warnings/main.ts deleted file mode 100644 index e69de29bb..000000000 diff --git a/tests/specs/run/allow_run_insecure_warnings/no_allow_list.out b/tests/specs/run/allow_run_insecure_warnings/no_allow_list.out deleted file mode 100644 index 293b4446a..000000000 --- a/tests/specs/run/allow_run_insecure_warnings/no_allow_list.out +++ /dev/null @@ -1 +0,0 @@ -Warning --allow-run without an allow list is susceptible to exploits. Prefer specifying an allow list (https://docs.deno.com/runtime/fundamentals/security/#running-subprocesses) -- cgit v1.2.3