From 7e68cce8159d55fd597f0da3e00f794200b9928f Mon Sep 17 00:00:00 2001 From: Marvin Hagemeister Date: Tue, 27 Aug 2024 11:27:10 +0200 Subject: fix(task): support tasks with colons in name in `deno run` (#25233) Fix task names containing a colon not being found with `deno run`. We were only checking for a `module not found` error message, but strings containing a colon throw a different error. Fixes https://github.com/denoland/deno/issues/25232 --- tests/specs/run/run_task/__test__.jsonc | 4 ++++ tests/specs/run/run_task/deno.json | 3 ++- tests/specs/run/run_task/main_foo.out | 2 ++ 3 files changed, 8 insertions(+), 1 deletion(-) create mode 100644 tests/specs/run/run_task/main_foo.out (limited to 'tests/specs/run/run_task') diff --git a/tests/specs/run/run_task/__test__.jsonc b/tests/specs/run/run_task/__test__.jsonc index 0d1c82efd..b53cca657 100644 --- a/tests/specs/run/run_task/__test__.jsonc +++ b/tests/specs/run/run_task/__test__.jsonc @@ -8,6 +8,10 @@ "args": "run not_found", "output": "not_found.out", "exitCode": 1 + }, + "deno_run_task_colon": { + "args": "run main:foo", + "output": "main_foo.out" } } } diff --git a/tests/specs/run/run_task/deno.json b/tests/specs/run/run_task/deno.json index 54772504e..3597b5b47 100644 --- a/tests/specs/run/run_task/deno.json +++ b/tests/specs/run/run_task/deno.json @@ -1,5 +1,6 @@ { "tasks": { - "main": "deno run main.ts" + "main": "deno run main.ts", + "main:foo": "deno run main.ts" } } diff --git a/tests/specs/run/run_task/main_foo.out b/tests/specs/run/run_task/main_foo.out new file mode 100644 index 000000000..7e5f82632 --- /dev/null +++ b/tests/specs/run/run_task/main_foo.out @@ -0,0 +1,2 @@ +Task main:foo deno run main.ts +main -- cgit v1.2.3