From 560ad0331bf99a2564f53201cd086ff902901bfe Mon Sep 17 00:00:00 2001 From: David Sherret Date: Mon, 9 Sep 2024 17:35:41 -0400 Subject: fix(node/byonm): do not accidentally resolve bare node built-ins (#25543) This was accidentally enabled in byonm, but it requires the `--unstable-bare-node-builtins` flag. Closes #25358 --- tests/specs/run/node_builtin_modules/__test__.jsonc | 12 ++++++++++++ tests/specs/run/node_builtin_modules/mod.js | 5 +++++ tests/specs/run/node_builtin_modules/mod.js.out | 3 +++ tests/specs/run/node_builtin_modules/mod.ts | 5 +++++ tests/specs/run/node_builtin_modules/mod.ts.out | 3 +++ 5 files changed, 28 insertions(+) create mode 100644 tests/specs/run/node_builtin_modules/__test__.jsonc create mode 100644 tests/specs/run/node_builtin_modules/mod.js create mode 100644 tests/specs/run/node_builtin_modules/mod.js.out create mode 100644 tests/specs/run/node_builtin_modules/mod.ts create mode 100644 tests/specs/run/node_builtin_modules/mod.ts.out (limited to 'tests/specs/run/node_builtin_modules') diff --git a/tests/specs/run/node_builtin_modules/__test__.jsonc b/tests/specs/run/node_builtin_modules/__test__.jsonc new file mode 100644 index 000000000..f3d637ac6 --- /dev/null +++ b/tests/specs/run/node_builtin_modules/__test__.jsonc @@ -0,0 +1,12 @@ +{ + "tests": { + "ts": { + "args": "run --quiet --allow-read mod.ts hello there", + "output": "mod.ts.out" + }, + "js": { + "args": "run --quiet --allow-read mod.js hello there", + "output": "mod.js.out" + } + } +} diff --git a/tests/specs/run/node_builtin_modules/mod.js b/tests/specs/run/node_builtin_modules/mod.js new file mode 100644 index 000000000..a01ac4422 --- /dev/null +++ b/tests/specs/run/node_builtin_modules/mod.js @@ -0,0 +1,5 @@ +import { createRequire } from "node:module"; +console.log(createRequire); +import process from "node:process"; +console.log(process.version); +console.log(process.argv); diff --git a/tests/specs/run/node_builtin_modules/mod.js.out b/tests/specs/run/node_builtin_modules/mod.js.out new file mode 100644 index 000000000..844e3d927 --- /dev/null +++ b/tests/specs/run/node_builtin_modules/mod.js.out @@ -0,0 +1,3 @@ +[Function: createRequire] +v[WILDCARD].[WILDCARD].[WILDCARD] +[ [Getter], [Getter], "hello", "there" ] diff --git a/tests/specs/run/node_builtin_modules/mod.ts b/tests/specs/run/node_builtin_modules/mod.ts new file mode 100644 index 000000000..a01ac4422 --- /dev/null +++ b/tests/specs/run/node_builtin_modules/mod.ts @@ -0,0 +1,5 @@ +import { createRequire } from "node:module"; +console.log(createRequire); +import process from "node:process"; +console.log(process.version); +console.log(process.argv); diff --git a/tests/specs/run/node_builtin_modules/mod.ts.out b/tests/specs/run/node_builtin_modules/mod.ts.out new file mode 100644 index 000000000..844e3d927 --- /dev/null +++ b/tests/specs/run/node_builtin_modules/mod.ts.out @@ -0,0 +1,3 @@ +[Function: createRequire] +v[WILDCARD].[WILDCARD].[WILDCARD] +[ [Getter], [Getter], "hello", "there" ] -- cgit v1.2.3