From a7531361ef9bcc29b31ca73b68eeae707ea91f22 Mon Sep 17 00:00:00 2001 From: Nathan Whitaker <17734409+nathanwhit@users.noreply.github.com> Date: Wed, 12 Jun 2024 16:06:41 -0700 Subject: fix(cli): Explicitly cache NPM packages during `deno install` (#24190) Fixes a regression introduced in https://github.com/denoland/deno/pull/24170, where we wouldn't actually set up the node modules dir on `deno install` if there was an up to date deno lockfile present. Previously we were relying on the fact that resolving pending module resolution called `cache_packages` (which sets up the node modules dir). When pending resolutions were removed, and the `resolve_pending` function with it, we also removed the `cache_packages` call needed to set up node modules. --- tests/specs/npm/npmrc_not_next_to_package_json/main.out | 1 + 1 file changed, 1 insertion(+) (limited to 'tests/specs/npm/npmrc_not_next_to_package_json') diff --git a/tests/specs/npm/npmrc_not_next_to_package_json/main.out b/tests/specs/npm/npmrc_not_next_to_package_json/main.out index 8f42fb6d8..933d44f1c 100644 --- a/tests/specs/npm/npmrc_not_next_to_package_json/main.out +++ b/tests/specs/npm/npmrc_not_next_to_package_json/main.out @@ -4,3 +4,4 @@ [WILDCARD] Download http://localhost:4260/@denotest/esm-basic/1.0.0.tgz Initialize @denotest/esm-basic@1.0.0 +[WILDCARD] -- cgit v1.2.3