From 5504acea6751480f1425c88353ad5d36257bdce7 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Bartek=20Iwa=C5=84czuk?= Date: Thu, 26 Sep 2024 02:50:54 +0100 Subject: feat: add `--allow-import` flag (#25469) This replaces `--allow-net` for import permissions and makes the security sandbox stricter by also checking permissions for statically analyzable imports. By default, this has a value of `--allow-import=deno.land:443,jsr.io:443,esm.sh:443,raw.githubusercontent.com:443,gist.githubusercontent.com:443`, but that can be overridden by providing a different set of hosts. Additionally, when no value is provided, import permissions are inferred from the CLI arguments so the following works because `fresh.deno.dev:443` will be added to the list of allowed imports: ```ts deno run -A -r https://fresh.deno.dev ``` --------- Co-authored-by: David Sherret --- .../specs/npm/nonexistent_file_node_modules_dir/__test__.jsonc | 10 ++++++++++ .../nonexistent_file_node_modules_dir/nonexistent_file/main.js | 2 ++ .../nonexistent_file/main.out | 4 ++++ 3 files changed, 16 insertions(+) create mode 100644 tests/specs/npm/nonexistent_file_node_modules_dir/__test__.jsonc create mode 100644 tests/specs/npm/nonexistent_file_node_modules_dir/nonexistent_file/main.js create mode 100644 tests/specs/npm/nonexistent_file_node_modules_dir/nonexistent_file/main.out (limited to 'tests/specs/npm/nonexistent_file_node_modules_dir') diff --git a/tests/specs/npm/nonexistent_file_node_modules_dir/__test__.jsonc b/tests/specs/npm/nonexistent_file_node_modules_dir/__test__.jsonc new file mode 100644 index 000000000..66595558f --- /dev/null +++ b/tests/specs/npm/nonexistent_file_node_modules_dir/__test__.jsonc @@ -0,0 +1,10 @@ +{ + "tempDir": true, + "args": "run -A --quiet --node-modules-dir nonexistent_file/main.js", + "output": "nonexistent_file/main.out", + "envs": { + "NO_COLOR": "1", + "NPM_CONFIG_REGISTRY": "http://localhost:4260/" + }, + "exitCode": 1 +} diff --git a/tests/specs/npm/nonexistent_file_node_modules_dir/nonexistent_file/main.js b/tests/specs/npm/nonexistent_file_node_modules_dir/nonexistent_file/main.js new file mode 100644 index 000000000..c480b0548 --- /dev/null +++ b/tests/specs/npm/nonexistent_file_node_modules_dir/nonexistent_file/main.js @@ -0,0 +1,2 @@ +import hmacSHA512 from "npm:crypto-js/non-existent"; +console.log(hmacSHA512); diff --git a/tests/specs/npm/nonexistent_file_node_modules_dir/nonexistent_file/main.out b/tests/specs/npm/nonexistent_file_node_modules_dir/nonexistent_file/main.out new file mode 100644 index 000000000..baa79b1ce --- /dev/null +++ b/tests/specs/npm/nonexistent_file_node_modules_dir/nonexistent_file/main.out @@ -0,0 +1,4 @@ +error: Unable to load [WILDCARD]non-existent imported from [WILDCARD]main.js + +Caused by: +[WILDCARD] -- cgit v1.2.3