From ce7dc2be92499f15b4b0315bfca3ee9d61fc3c5e Mon Sep 17 00:00:00 2001
From: Nathan Whitaker <17734409+nathanwhit@users.noreply.github.com>
Date: Tue, 9 Jul 2024 20:06:08 -0700
Subject: feat(node): Support executing npm package lifecycle scripts
 (preinstall/install/postinstall) (#24487)

Adds support for running npm package lifecycle scripts, opted into via a
new `--allow-scripts` flag.

With this PR, when running `deno cache` (or `DENO_FUTURE=1 deno
install`) you can specify the `--allow-scripts=pkg1,pkg2` flag to run
lifecycle scripts attached to the given packages.

Note at the moment this only works when `nodeModulesDir` is true (using
the local resolver).

When a package with un-run lifecycle scripts is encountered, we emit a
warning suggesting things may not work and to try running lifecycle
scripts. Additionally, if a package script implicitly requires
`node-gyp` and it's not found on the system, we emit a warning.

Extra things in this PR:
- Extracted out bits of `task.rs` into a separate module for reuse
- Added a couple fields to `process.config` in order to support
`node-gyp` (it relies on a few variables being there)
- Drive by fix to downloading new npm packages to test registry

---

TODO:
- [x] validation for allow-scripts args (make sure it looks like an npm
package)
- [x] make allow-scripts matching smarter
- [ ] figure out what issues this closes

---
Review notes:
- This adds a bunch of deps to our test registry due to using
`node-gyp`, so it's pretty noisy
---
 tests/specs/npm/lifecycle_scripts/implicit_node_gyp.js | 3 +++
 1 file changed, 3 insertions(+)
 create mode 100644 tests/specs/npm/lifecycle_scripts/implicit_node_gyp.js

(limited to 'tests/specs/npm/lifecycle_scripts/implicit_node_gyp.js')

diff --git a/tests/specs/npm/lifecycle_scripts/implicit_node_gyp.js b/tests/specs/npm/lifecycle_scripts/implicit_node_gyp.js
new file mode 100644
index 000000000..2301aa626
--- /dev/null
+++ b/tests/specs/npm/lifecycle_scripts/implicit_node_gyp.js
@@ -0,0 +1,3 @@
+import { hello } from "npm:@denotest/node-addon-implicit-node-gyp@1.0.0";
+
+console.log(hello());
-- 
cgit v1.2.3