From 5504acea6751480f1425c88353ad5d36257bdce7 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Bartek=20Iwa=C5=84czuk?= Date: Thu, 26 Sep 2024 02:50:54 +0100 Subject: feat: add `--allow-import` flag (#25469) This replaces `--allow-net` for import permissions and makes the security sandbox stricter by also checking permissions for statically analyzable imports. By default, this has a value of `--allow-import=deno.land:443,jsr.io:443,esm.sh:443,raw.githubusercontent.com:443,gist.githubusercontent.com:443`, but that can be overridden by providing a different set of hosts. Additionally, when no value is provided, import permissions are inferred from the CLI arguments so the following works because `fresh.deno.dev:443` will be added to the list of allowed imports: ```ts deno run -A -r https://fresh.deno.dev ``` --------- Co-authored-by: David Sherret --- tests/specs/npm/dynamic_import_reload_same_package/__test__.jsonc | 8 ++++++++ .../dynamic_import_reload_same_package/main.out | 5 +++++ .../dynamic_import_reload_same_package/main.ts | 7 +++++++ .../dynamic_import_reload_same_package/other.ts | 3 +++ 4 files changed, 23 insertions(+) create mode 100644 tests/specs/npm/dynamic_import_reload_same_package/__test__.jsonc create mode 100644 tests/specs/npm/dynamic_import_reload_same_package/dynamic_import_reload_same_package/main.out create mode 100644 tests/specs/npm/dynamic_import_reload_same_package/dynamic_import_reload_same_package/main.ts create mode 100644 tests/specs/npm/dynamic_import_reload_same_package/dynamic_import_reload_same_package/other.ts (limited to 'tests/specs/npm/dynamic_import_reload_same_package') diff --git a/tests/specs/npm/dynamic_import_reload_same_package/__test__.jsonc b/tests/specs/npm/dynamic_import_reload_same_package/__test__.jsonc new file mode 100644 index 000000000..d255b9a87 --- /dev/null +++ b/tests/specs/npm/dynamic_import_reload_same_package/__test__.jsonc @@ -0,0 +1,8 @@ +{ + "args": "run -A --reload dynamic_import_reload_same_package/main.ts", + "output": "dynamic_import_reload_same_package/main.out", + "envs": { + "NO_COLOR": "1", + "NPM_CONFIG_REGISTRY": "http://localhost:4260/" + } +} diff --git a/tests/specs/npm/dynamic_import_reload_same_package/dynamic_import_reload_same_package/main.out b/tests/specs/npm/dynamic_import_reload_same_package/dynamic_import_reload_same_package/main.out new file mode 100644 index 000000000..b2f99b465 --- /dev/null +++ b/tests/specs/npm/dynamic_import_reload_same_package/dynamic_import_reload_same_package/main.out @@ -0,0 +1,5 @@ +Download http://localhost:4260/chalk +Download http://localhost:4260/chalk/chalk-5.0.1.tgz +Starting... +Ran other. +Finished... diff --git a/tests/specs/npm/dynamic_import_reload_same_package/dynamic_import_reload_same_package/main.ts b/tests/specs/npm/dynamic_import_reload_same_package/dynamic_import_reload_same_package/main.ts new file mode 100644 index 000000000..7c7ee7d55 --- /dev/null +++ b/tests/specs/npm/dynamic_import_reload_same_package/dynamic_import_reload_same_package/main.ts @@ -0,0 +1,7 @@ +import chalk from "npm:chalk@5"; + +console.log(chalk.green("Starting...")); +// non-analyzable +const importName = "./other.ts"; +await import(importName); +console.log(chalk.green("Finished...")); diff --git a/tests/specs/npm/dynamic_import_reload_same_package/dynamic_import_reload_same_package/other.ts b/tests/specs/npm/dynamic_import_reload_same_package/dynamic_import_reload_same_package/other.ts new file mode 100644 index 000000000..28e3da14f --- /dev/null +++ b/tests/specs/npm/dynamic_import_reload_same_package/dynamic_import_reload_same_package/other.ts @@ -0,0 +1,3 @@ +import chalk from "npm:chalk@5"; + +console.log(chalk.green("Ran other.")); -- cgit v1.2.3