From 52ababc4bf948904092cff54c2ab8b91f6b9b443 Mon Sep 17 00:00:00 2001 From: David Sherret Date: Tue, 23 Jul 2024 20:22:24 -0400 Subject: fix(node): better detection for when to surface node resolution errors (#24653) --- .../specs/node/byonm_phantom_dep_res_failure/__test__.jsonc | 13 +++++++++++++ .../specs/node/byonm_phantom_dep_res_failure/bad_import.out | 2 ++ .../specs/node/byonm_phantom_dep_res_failure/bad_import.ts | 3 +++ tests/specs/node/byonm_phantom_dep_res_failure/deno.json | 3 +++ .../node/byonm_phantom_dep_res_failure/good_import.out | 1 + .../specs/node/byonm_phantom_dep_res_failure/good_import.ts | 3 +++ .../node_modules/package/main.js | 1 + .../node_modules/package/package.json | 4 ++++ tests/specs/node/byonm_phantom_dep_res_failure/package.json | 2 ++ 9 files changed, 32 insertions(+) create mode 100644 tests/specs/node/byonm_phantom_dep_res_failure/__test__.jsonc create mode 100644 tests/specs/node/byonm_phantom_dep_res_failure/bad_import.out create mode 100644 tests/specs/node/byonm_phantom_dep_res_failure/bad_import.ts create mode 100644 tests/specs/node/byonm_phantom_dep_res_failure/deno.json create mode 100644 tests/specs/node/byonm_phantom_dep_res_failure/good_import.out create mode 100644 tests/specs/node/byonm_phantom_dep_res_failure/good_import.ts create mode 100644 tests/specs/node/byonm_phantom_dep_res_failure/node_modules/package/main.js create mode 100644 tests/specs/node/byonm_phantom_dep_res_failure/node_modules/package/package.json create mode 100644 tests/specs/node/byonm_phantom_dep_res_failure/package.json (limited to 'tests/specs/node') diff --git a/tests/specs/node/byonm_phantom_dep_res_failure/__test__.jsonc b/tests/specs/node/byonm_phantom_dep_res_failure/__test__.jsonc new file mode 100644 index 000000000..35e0a7686 --- /dev/null +++ b/tests/specs/node/byonm_phantom_dep_res_failure/__test__.jsonc @@ -0,0 +1,13 @@ +{ + "tests": { + "bad_import": { + "args": "run bad_import.ts", + "output": "bad_import.out", + "exitCode": 1 + }, + "good_import": { + "args": "run good_import.ts", + "output": "good_import.out" + } + } +} diff --git a/tests/specs/node/byonm_phantom_dep_res_failure/bad_import.out b/tests/specs/node/byonm_phantom_dep_res_failure/bad_import.out new file mode 100644 index 000000000..a524720e3 --- /dev/null +++ b/tests/specs/node/byonm_phantom_dep_res_failure/bad_import.out @@ -0,0 +1,2 @@ +error: [ERR_MODULE_NOT_FOUND] Cannot find module 'file:///[WILDLINE]/node_modules/package/index.js' imported from 'file:///[WILDLINE]/bad_import.ts' + at file:///[WILDLINE]/bad_import.ts:1:16 diff --git a/tests/specs/node/byonm_phantom_dep_res_failure/bad_import.ts b/tests/specs/node/byonm_phantom_dep_res_failure/bad_import.ts new file mode 100644 index 000000000..e20fe1fcf --- /dev/null +++ b/tests/specs/node/byonm_phantom_dep_res_failure/bad_import.ts @@ -0,0 +1,3 @@ +import hi from "package"; + +hi(); diff --git a/tests/specs/node/byonm_phantom_dep_res_failure/deno.json b/tests/specs/node/byonm_phantom_dep_res_failure/deno.json new file mode 100644 index 000000000..6134d86d1 --- /dev/null +++ b/tests/specs/node/byonm_phantom_dep_res_failure/deno.json @@ -0,0 +1,3 @@ +{ + "unstable": ["byonm"] +} diff --git a/tests/specs/node/byonm_phantom_dep_res_failure/good_import.out b/tests/specs/node/byonm_phantom_dep_res_failure/good_import.out new file mode 100644 index 000000000..45b983be3 --- /dev/null +++ b/tests/specs/node/byonm_phantom_dep_res_failure/good_import.out @@ -0,0 +1 @@ +hi diff --git a/tests/specs/node/byonm_phantom_dep_res_failure/good_import.ts b/tests/specs/node/byonm_phantom_dep_res_failure/good_import.ts new file mode 100644 index 000000000..2b17d3e33 --- /dev/null +++ b/tests/specs/node/byonm_phantom_dep_res_failure/good_import.ts @@ -0,0 +1,3 @@ +import hi from "package/main.js"; + +hi(); diff --git a/tests/specs/node/byonm_phantom_dep_res_failure/node_modules/package/main.js b/tests/specs/node/byonm_phantom_dep_res_failure/node_modules/package/main.js new file mode 100644 index 000000000..bc76b8e9e --- /dev/null +++ b/tests/specs/node/byonm_phantom_dep_res_failure/node_modules/package/main.js @@ -0,0 +1 @@ +module.exports = () => console.log('hi'); \ No newline at end of file diff --git a/tests/specs/node/byonm_phantom_dep_res_failure/node_modules/package/package.json b/tests/specs/node/byonm_phantom_dep_res_failure/node_modules/package/package.json new file mode 100644 index 000000000..5723987e9 --- /dev/null +++ b/tests/specs/node/byonm_phantom_dep_res_failure/node_modules/package/package.json @@ -0,0 +1,4 @@ +{ + "name": "package", + "version": "1.0.0" +} \ No newline at end of file diff --git a/tests/specs/node/byonm_phantom_dep_res_failure/package.json b/tests/specs/node/byonm_phantom_dep_res_failure/package.json new file mode 100644 index 000000000..2c63c0851 --- /dev/null +++ b/tests/specs/node/byonm_phantom_dep_res_failure/package.json @@ -0,0 +1,2 @@ +{ +} -- cgit v1.2.3