From a7531361ef9bcc29b31ca73b68eeae707ea91f22 Mon Sep 17 00:00:00 2001 From: Nathan Whitaker <17734409+nathanwhit@users.noreply.github.com> Date: Wed, 12 Jun 2024 16:06:41 -0700 Subject: fix(cli): Explicitly cache NPM packages during `deno install` (#24190) Fixes a regression introduced in https://github.com/denoland/deno/pull/24170, where we wouldn't actually set up the node modules dir on `deno install` if there was an up to date deno lockfile present. Previously we were relying on the fact that resolving pending module resolution called `cache_packages` (which sets up the node modules dir). When pending resolutions were removed, and the `resolve_pending` function with it, we also removed the `cache_packages` call needed to set up node modules. --- tests/specs/install/future_install_node_modules/install_lockfile.out | 2 ++ 1 file changed, 2 insertions(+) create mode 100644 tests/specs/install/future_install_node_modules/install_lockfile.out (limited to 'tests/specs/install/future_install_node_modules/install_lockfile.out') diff --git a/tests/specs/install/future_install_node_modules/install_lockfile.out b/tests/specs/install/future_install_node_modules/install_lockfile.out new file mode 100644 index 000000000..3e27e3d20 --- /dev/null +++ b/tests/specs/install/future_install_node_modules/install_lockfile.out @@ -0,0 +1,2 @@ +⚠️ `deno install` behavior will change in Deno 2. To preserve the current behavior use the `-g` or `--global` flag. +Initialize @denotest/esm-basic@1.0.0 -- cgit v1.2.3