From f091d1ad69b4e5217ae3272b641171781a372c4f Mon Sep 17 00:00:00 2001
From: David Sherret <dsherret@users.noreply.github.com>
Date: Wed, 13 Nov 2024 10:10:09 -0500
Subject: feat(node): stabilize detecting if CJS via `"type": "commonjs"` in a
 package.json (#26439)

This will respect `"type": "commonjs"` in a package.json to determine if
`.js`/`.jsx`/`.ts`/.tsx` files are CJS or ESM. If the file is found to
be ESM it will be loaded as ESM though.
---
 tests/specs/compile/detect_cjs/__test__.jsonc | 27 ---------------------------
 tests/specs/compile/detect_cjs/add.js         |  3 ---
 tests/specs/compile/detect_cjs/compile.out    |  2 --
 tests/specs/compile/detect_cjs/deno.json      |  5 -----
 tests/specs/compile/detect_cjs/main.js        |  3 ---
 tests/specs/compile/detect_cjs/output.out     |  1 -
 tests/specs/compile/detect_cjs/package.json   |  6 ------
 tests/specs/compile/detect_cjs/subtract.ts    |  2 --
 8 files changed, 49 deletions(-)
 delete mode 100644 tests/specs/compile/detect_cjs/__test__.jsonc
 delete mode 100644 tests/specs/compile/detect_cjs/add.js
 delete mode 100644 tests/specs/compile/detect_cjs/compile.out
 delete mode 100644 tests/specs/compile/detect_cjs/deno.json
 delete mode 100644 tests/specs/compile/detect_cjs/main.js
 delete mode 100644 tests/specs/compile/detect_cjs/output.out
 delete mode 100644 tests/specs/compile/detect_cjs/package.json
 delete mode 100644 tests/specs/compile/detect_cjs/subtract.ts

(limited to 'tests/specs/compile/detect_cjs')

diff --git a/tests/specs/compile/detect_cjs/__test__.jsonc b/tests/specs/compile/detect_cjs/__test__.jsonc
deleted file mode 100644
index 0abf121f0..000000000
--- a/tests/specs/compile/detect_cjs/__test__.jsonc
+++ /dev/null
@@ -1,27 +0,0 @@
-{
-  "tempDir": true,
-  "steps": [{
-    "args": "install",
-    "output": "[WILDCARD]"
-  }, {
-    "if": "unix",
-    "args": "compile --output main main.js",
-    "output": "compile.out"
-  }, {
-    "if": "unix",
-    "commandName": "./main",
-    "args": [],
-    "output": "output.out",
-    "exitCode": 0
-  }, {
-    "if": "windows",
-    "args": "compile --output main.exe main.js",
-    "output": "compile.out"
-  }, {
-    "if": "windows",
-    "commandName": "./main.exe",
-    "args": [],
-    "output": "output.out",
-    "exitCode": 0
-  }]
-}
diff --git a/tests/specs/compile/detect_cjs/add.js b/tests/specs/compile/detect_cjs/add.js
deleted file mode 100644
index 94b0263f0..000000000
--- a/tests/specs/compile/detect_cjs/add.js
+++ /dev/null
@@ -1,3 +0,0 @@
-module.exports.add = function (a, b) {
-  return require("./subtract.ts").subtract(a, -b);
-};
diff --git a/tests/specs/compile/detect_cjs/compile.out b/tests/specs/compile/detect_cjs/compile.out
deleted file mode 100644
index 913e363c3..000000000
--- a/tests/specs/compile/detect_cjs/compile.out
+++ /dev/null
@@ -1,2 +0,0 @@
-Check file:///[WILDLINE]/main.js
-Compile file:///[WILDLINE]
diff --git a/tests/specs/compile/detect_cjs/deno.json b/tests/specs/compile/detect_cjs/deno.json
deleted file mode 100644
index 35f64c86f..000000000
--- a/tests/specs/compile/detect_cjs/deno.json
+++ /dev/null
@@ -1,5 +0,0 @@
-{
-  "unstable": [
-    "detect-cjs"
-  ]
-}
diff --git a/tests/specs/compile/detect_cjs/main.js b/tests/specs/compile/detect_cjs/main.js
deleted file mode 100644
index 8c55f673b..000000000
--- a/tests/specs/compile/detect_cjs/main.js
+++ /dev/null
@@ -1,3 +0,0 @@
-import { add } from "./add.js";
-
-console.log(add(1, 2));
diff --git a/tests/specs/compile/detect_cjs/output.out b/tests/specs/compile/detect_cjs/output.out
deleted file mode 100644
index 00750edc0..000000000
--- a/tests/specs/compile/detect_cjs/output.out
+++ /dev/null
@@ -1 +0,0 @@
-3
diff --git a/tests/specs/compile/detect_cjs/package.json b/tests/specs/compile/detect_cjs/package.json
deleted file mode 100644
index 6e65b32ed..000000000
--- a/tests/specs/compile/detect_cjs/package.json
+++ /dev/null
@@ -1,6 +0,0 @@
-{
-  "type": "commonjs",
-  "dependencies": {
-    "@types/node": "*"
-  }
-}
diff --git a/tests/specs/compile/detect_cjs/subtract.ts b/tests/specs/compile/detect_cjs/subtract.ts
deleted file mode 100644
index e4f6760b7..000000000
--- a/tests/specs/compile/detect_cjs/subtract.ts
+++ /dev/null
@@ -1,2 +0,0 @@
-/// <reference types="npm:@types/node" />
-module.exports.subtract = (a: number, b: number) => a - b;
-- 
cgit v1.2.3