From a49d0bd10ba2a4745c291f3f413d97396213e4ec Mon Sep 17 00:00:00 2001 From: David Sherret Date: Wed, 10 Jul 2024 14:46:25 -0400 Subject: fix(check): CJS types importing dual ESM/CJS package should prefer CJS types (#24492) Closes #16370 --- tests/registry/npm/@denotest/cjs-import-dual/1.0.0/index.d.ts | 2 ++ tests/registry/npm/@denotest/cjs-import-dual/1.0.0/index.js | 1 + tests/registry/npm/@denotest/cjs-import-dual/1.0.0/package.json | 7 +++++++ tests/registry/npm/@denotest/dual-cjs-esm/1.0.0/main.d.cts | 2 +- tests/registry/npm/@denotest/dual-cjs-esm/1.0.0/main.d.mts | 2 +- 5 files changed, 12 insertions(+), 2 deletions(-) create mode 100644 tests/registry/npm/@denotest/cjs-import-dual/1.0.0/index.d.ts create mode 100644 tests/registry/npm/@denotest/cjs-import-dual/1.0.0/index.js create mode 100644 tests/registry/npm/@denotest/cjs-import-dual/1.0.0/package.json (limited to 'tests/registry') diff --git a/tests/registry/npm/@denotest/cjs-import-dual/1.0.0/index.d.ts b/tests/registry/npm/@denotest/cjs-import-dual/1.0.0/index.d.ts new file mode 100644 index 000000000..55aaea82e --- /dev/null +++ b/tests/registry/npm/@denotest/cjs-import-dual/1.0.0/index.d.ts @@ -0,0 +1,2 @@ +// it should pick up the cjs types +export { getKind } from "@denotest/dual-cjs-esm"; diff --git a/tests/registry/npm/@denotest/cjs-import-dual/1.0.0/index.js b/tests/registry/npm/@denotest/cjs-import-dual/1.0.0/index.js new file mode 100644 index 000000000..45afec736 --- /dev/null +++ b/tests/registry/npm/@denotest/cjs-import-dual/1.0.0/index.js @@ -0,0 +1 @@ +module.exports.getKind = require("@denotest/dual-cjs-esm").getKind; diff --git a/tests/registry/npm/@denotest/cjs-import-dual/1.0.0/package.json b/tests/registry/npm/@denotest/cjs-import-dual/1.0.0/package.json new file mode 100644 index 000000000..78eb8d515 --- /dev/null +++ b/tests/registry/npm/@denotest/cjs-import-dual/1.0.0/package.json @@ -0,0 +1,7 @@ +{ + "name": "@denotest/cjs-import-dual", + "version": "1.0.0", + "dependencies": { + "@denotest/dual-cjs-esm": "1" + } +} \ No newline at end of file diff --git a/tests/registry/npm/@denotest/dual-cjs-esm/1.0.0/main.d.cts b/tests/registry/npm/@denotest/dual-cjs-esm/1.0.0/main.d.cts index f969ba996..3b231fa31 100644 --- a/tests/registry/npm/@denotest/dual-cjs-esm/1.0.0/main.d.cts +++ b/tests/registry/npm/@denotest/dual-cjs-esm/1.0.0/main.d.cts @@ -1 +1 @@ -export function getKind(): string; +export function getKind(): "cjs"; diff --git a/tests/registry/npm/@denotest/dual-cjs-esm/1.0.0/main.d.mts b/tests/registry/npm/@denotest/dual-cjs-esm/1.0.0/main.d.mts index f969ba996..ef69c885d 100644 --- a/tests/registry/npm/@denotest/dual-cjs-esm/1.0.0/main.d.mts +++ b/tests/registry/npm/@denotest/dual-cjs-esm/1.0.0/main.d.mts @@ -1 +1 @@ -export function getKind(): string; +export function getKind(): "esm"; -- cgit v1.2.3