From 897159dc6e1b2319cf2f5f09d8d6cecc0d3175fa Mon Sep 17 00:00:00 2001 From: snek Date: Tue, 6 Aug 2024 14:52:53 +0200 Subject: feat: vm rewrite (#24596) rewrite vm implementation to increase compat. vm.Module+importModuleDynamically callbacks should be added in a followup. --- .../test-vm-attributes-property-not-on-sandbox.js | 25 ++++++++++++++++++++++ 1 file changed, 25 insertions(+) create mode 100644 tests/node_compat/test/parallel/test-vm-attributes-property-not-on-sandbox.js (limited to 'tests/node_compat/test/parallel/test-vm-attributes-property-not-on-sandbox.js') diff --git a/tests/node_compat/test/parallel/test-vm-attributes-property-not-on-sandbox.js b/tests/node_compat/test/parallel/test-vm-attributes-property-not-on-sandbox.js new file mode 100644 index 000000000..940fd4e7f --- /dev/null +++ b/tests/node_compat/test/parallel/test-vm-attributes-property-not-on-sandbox.js @@ -0,0 +1,25 @@ +// deno-fmt-ignore-file +// deno-lint-ignore-file + +// Copyright Joyent and Node contributors. All rights reserved. MIT license. +// Taken from Node 18.12.1 +// This file is automatically generated by `tests/node_compat/runner/setup.ts`. Do not modify this file manually. + +'use strict'; +require('../common'); +const assert = require('assert'); +const vm = require('vm'); + +// Assert that accessor descriptors are not flattened on the sandbox. +// Issue: https://github.com/nodejs/node/issues/2734 +const sandbox = {}; +vm.createContext(sandbox); +const code = `Object.defineProperty( + this, + 'foo', + { get: function() {return 17} } + ); + var desc = Object.getOwnPropertyDescriptor(this, 'foo');`; + +vm.runInContext(code, sandbox); +assert.strictEqual(typeof sandbox.desc.get, 'function'); -- cgit v1.2.3