From 6a356aff1380e79d67738c5b43aa2b5fee76600d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Bartek=20Iwa=C5=84czuk?= Date: Tue, 11 Jun 2024 12:41:44 +0100 Subject: chore: sync up Node.js test files for v20.11.1 (#24066) Co-authored-by: Yoshiya Hinosawa --- .../node_compat/test/parallel/test-diagnostics-channel-pub-sub.js | 7 +++++++ 1 file changed, 7 insertions(+) (limited to 'tests/node_compat/test/parallel/test-diagnostics-channel-pub-sub.js') diff --git a/tests/node_compat/test/parallel/test-diagnostics-channel-pub-sub.js b/tests/node_compat/test/parallel/test-diagnostics-channel-pub-sub.js index 8a8554823..ef2486f5a 100644 --- a/tests/node_compat/test/parallel/test-diagnostics-channel-pub-sub.js +++ b/tests/node_compat/test/parallel/test-diagnostics-channel-pub-sub.js @@ -49,3 +49,10 @@ assert.ok(!dc.unsubscribe(name, subscriber)); assert.throws(() => { dc.subscribe(name, null); }, { code: 'ERR_INVALID_ARG_TYPE' }); + +// Reaching zero subscribers should not delete from the channels map as there +// will be no more weakref to incRef if another subscribe happens while the +// channel object itself exists. +channel.subscribe(subscriber); +channel.unsubscribe(subscriber); +channel.subscribe(subscriber); -- cgit v1.2.3