From 897159dc6e1b2319cf2f5f09d8d6cecc0d3175fa Mon Sep 17 00:00:00 2001 From: snek Date: Tue, 6 Aug 2024 14:52:53 +0200 Subject: feat: vm rewrite (#24596) rewrite vm implementation to increase compat. vm.Module+importModuleDynamically callbacks should be added in a followup. --- tests/node_compat/test/common/index.js | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) (limited to 'tests/node_compat/test/common') diff --git a/tests/node_compat/test/common/index.js b/tests/node_compat/test/common/index.js index ebac56ac5..d2165aecd 100644 --- a/tests/node_compat/test/common/index.js +++ b/tests/node_compat/test/common/index.js @@ -16,7 +16,6 @@ const path = require("path"); const util = require("util"); const tmpdir = require("./tmpdir"); - function platformTimeout(ms) { return ms; } @@ -90,7 +89,7 @@ function allowGlobals(...allowlist) { if (process.env.NODE_TEST_KNOWN_GLOBALS !== '0') { if (process.env.NODE_TEST_KNOWN_GLOBALS) { - const knownFromEnv = process.env.NODE_TEST_KNOWN_GLOBALS.split(','); + const knownFromEnv = process.env.NODE_TEST_KNOWN_GLOBALS.split(',').map((name) => global[name]); allowGlobals(...knownFromEnv); } @@ -445,13 +444,13 @@ const pwdCommand = isWindows ? function spawnPromisified(...args) { let stderr = ''; let stdout = ''; - + const child = spawn(...args); child.stderr.setEncoding('utf8'); child.stderr.on('data', (data) => { stderr += data; }); child.stdout.setEncoding('utf8'); child.stdout.on('data', (data) => { stdout += data; }); - + return new Promise((resolve, reject) => { child.on('close', (code, signal) => { resolve({ -- cgit v1.2.3