From ce7dc2be92499f15b4b0315bfca3ee9d61fc3c5e Mon Sep 17 00:00:00 2001
From: Nathan Whitaker <17734409+nathanwhit@users.noreply.github.com>
Date: Tue, 9 Jul 2024 20:06:08 -0700
Subject: feat(node): Support executing npm package lifecycle scripts
 (preinstall/install/postinstall) (#24487)

Adds support for running npm package lifecycle scripts, opted into via a
new `--allow-scripts` flag.

With this PR, when running `deno cache` (or `DENO_FUTURE=1 deno
install`) you can specify the `--allow-scripts=pkg1,pkg2` flag to run
lifecycle scripts attached to the given packages.

Note at the moment this only works when `nodeModulesDir` is true (using
the local resolver).

When a package with un-run lifecycle scripts is encountered, we emit a
warning suggesting things may not work and to try running lifecycle
scripts. Additionally, if a package script implicitly requires
`node-gyp` and it's not found on the system, we emit a warning.

Extra things in this PR:
- Extracted out bits of `task.rs` into a separate module for reuse
- Added a couple fields to `process.config` in order to support
`node-gyp` (it relies on a few variables being there)
- Drive by fix to downloading new npm packages to test registry

---

TODO:
- [x] validation for allow-scripts args (make sure it looks like an npm
package)
- [x] make allow-scripts matching smarter
- [ ] figure out what issues this closes

---
Review notes:
- This adds a bunch of deps to our test registry due to using
`node-gyp`, so it's pretty noisy
---
 tests/integration/npm_tests.rs | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

(limited to 'tests/integration/npm_tests.rs')

diff --git a/tests/integration/npm_tests.rs b/tests/integration/npm_tests.rs
index 871f09d15..82f0697d5 100644
--- a/tests/integration/npm_tests.rs
+++ b/tests/integration/npm_tests.rs
@@ -950,9 +950,13 @@ fn ensure_registry_files_local() {
       let registry_json_path = registry_dir_path
         .join(entry.file_name())
         .join("registry.json");
+
       if registry_json_path.exists() {
         let file_text = std::fs::read_to_string(&registry_json_path).unwrap();
-        if file_text.contains("https://registry.npmjs.org/") {
+        if file_text.contains(&format!(
+          "https://registry.npmjs.org/{}/-/",
+          entry.file_name().to_string_lossy()
+        )) {
           panic!(
             "file {} contained a reference to the npm registry",
             registry_json_path
-- 
cgit v1.2.3