From 39f131cd762e62e6750b61a5edd6ed0e83995a77 Mon Sep 17 00:00:00 2001
From: Divy Srivastava <dj.srivastava23@gmail.com>
Date: Fri, 10 Feb 2023 21:46:56 +0530
Subject: fix(cli/napi): correct name handling in napi property descriptor
 (#17716)

Fixes https://github.com/denoland/deno/issues/17712
---
 test_napi/properties_test.js |  6 ++++++
 test_napi/src/properties.rs  | 41 ++++++++++++++++++++---------------------
 2 files changed, 26 insertions(+), 21 deletions(-)

(limited to 'test_napi')

diff --git a/test_napi/properties_test.js b/test_napi/properties_test.js
index 36ede1033..b5f0c0794 100644
--- a/test_napi/properties_test.js
+++ b/test_napi/properties_test.js
@@ -15,4 +15,10 @@ Deno.test("napi properties", () => {
   assertEquals(properties.test_simple_property, {
     nice: 69,
   });
+
+  assertEquals(properties.key_v8_string, 1);
+  const symbols = Object.getOwnPropertySymbols(properties);
+  assertEquals(symbols.length, 1);
+  assertEquals(symbols[0].description, "key_v8_symbol");
+  assertEquals(properties[symbols[0]], 1);
 });
diff --git a/test_napi/src/properties.rs b/test_napi/src/properties.rs
index 1b6c9488b..339699a05 100644
--- a/test_napi/src/properties.rs
+++ b/test_napi/src/properties.rs
@@ -82,27 +82,26 @@ pub fn init(env: napi_env, exports: napi_value) {
       attributes: enumerable,
       value: number,
     },
-    // TODO(@littledivy): Fix this.
-    // napi_property_descriptor {
-    //   utf8name: ptr::null(),
-    //   name: name_value,
-    //   method: None,
-    //   getter: None,
-    //   setter: None,
-    //   data: ptr::null_mut(),
-    //   attributes: enumerable,
-    //   value: number,
-    // },
-    // napi_property_descriptor {
-    //   utf8name: ptr::null(),
-    //   name: name_symbol,
-    //   method: None,
-    //   getter: None,
-    //   setter: None,
-    //   data: ptr::null_mut(),
-    //   attributes: enumerable,
-    //   value: number,
-    // },
+    napi_property_descriptor {
+      utf8name: ptr::null(),
+      name: name_value,
+      method: None,
+      getter: None,
+      setter: None,
+      data: ptr::null_mut(),
+      attributes: enumerable,
+      value: number,
+    },
+    napi_property_descriptor {
+      utf8name: ptr::null(),
+      name: name_symbol,
+      method: None,
+      getter: None,
+      setter: None,
+      data: ptr::null_mut(),
+      attributes: enumerable,
+      value: number,
+    },
   ];
 
   assert_napi_ok!(napi_define_properties(
-- 
cgit v1.2.3