From a2488ae79200abfcbad0f0f8b084a3ff8e183880 Mon Sep 17 00:00:00 2001 From: Luke Channings <461449+LukeChannings@users.noreply.github.com> Date: Mon, 10 Oct 2022 03:29:31 +0100 Subject: fix(npm): support compiling on linux/aarch64 (#16208) Changes introduced in #13633 have broken the ability to compile for linux/aarch64 - specifically the use of a `i8` as a char type, which is an `u8` on linux/aarch64. This PR: - Replaces instances of `i8` with the architecture-aware wrapper type `c_char` - Skips the use of `--export-dynamic-symbol` on linux-aarch64, because the target environments often rely on older libc/binutils versions --- test_napi/src/async.rs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'test_napi/src/async.rs') diff --git a/test_napi/src/async.rs b/test_napi/src/async.rs index d14871a7c..53432de7c 100644 --- a/test_napi/src/async.rs +++ b/test_napi/src/async.rs @@ -3,7 +3,7 @@ use napi_sys::Status::napi_ok; use napi_sys::ValueType::napi_function; use napi_sys::*; -use std::os::raw::c_void; +use std::os::raw::{c_char, c_void}; use std::ptr; pub struct Baton { @@ -62,7 +62,7 @@ extern "C" fn test_async_work( unsafe { napi_create_string_utf8( env, - "test_async_resource\0".as_ptr() as *const i8, + "test_async_resource\0".as_ptr() as *const c_char, usize::MAX, &mut resource_name, ) -- cgit v1.2.3