From da201d9ea5e00f7fd2aefc3222759f3c253c1882 Mon Sep 17 00:00:00 2001 From: Aapo Alasuutari Date: Sun, 5 Mar 2023 10:01:23 +0200 Subject: feat(ext/ffi): Make External pointers keep reference to V8 buffer (#17955) --- test_ffi/tests/bench.js | 6 ------ 1 file changed, 6 deletions(-) (limited to 'test_ffi/tests') diff --git a/test_ffi/tests/bench.js b/test_ffi/tests/bench.js index b70b41e8f..a3983fb2b 100644 --- a/test_ffi/tests/bench.js +++ b/test_ffi/tests/bench.js @@ -354,8 +354,6 @@ Deno.bench("nop_f64()", () => { const { nop_buffer } = dylib.symbols; const buffer = new Uint8Array(8).fill(5); -// Make sure the buffer does not get collected -globalThis.buffer = buffer; Deno.bench("nop_buffer()", () => { nop_buffer(buffer); }); @@ -565,8 +563,6 @@ Deno.bench("return_buffer_nonblocking()", async () => { const { nop_many_parameters } = dylib.symbols; const buffer2 = new Uint8Array(8).fill(25); -// Make sure the buffer does not get collected -globalThis.buffer2 = buffer2; Deno.bench("nop_many_parameters()", () => { nop_many_parameters( 135, @@ -635,8 +631,6 @@ Deno.bench("Deno.UnsafePointer.of", () => { }); const cstringBuffer = new TextEncoder().encode("Best believe it!\0"); -// Make sure the buffer does not get collected -globalThis.cstringBuffer = cstringBuffer; const cstringPointerView = new Deno.UnsafePointerView( Deno.UnsafePointer.of(cstringBuffer), ); -- cgit v1.2.3