From 427b73c3ec1e01ca8c670d403a85fcf31777d253 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Bartek=20Iwa=C5=84czuk?= Date: Tue, 23 Jan 2024 15:33:07 +0100 Subject: feat: warn when using --unstable, prefer granular flags (#21452) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This commit deprecates "--unstable" flag. When "--unstable" flag is encountered a warning like this is printed: ``` The `--unstable` flag is deprecated, use granular `--unstable-*` flags instead. Learn more at: https://docs.deno.com/runtime/manual/tools/unstable_flags ``` When "--unstable" flag is used and an unstable API is called an additional warning like this is printed for each API call: ``` The `Deno.dlopen` API was used with `--unstable` flag. The `--unstable` flag is deprecated, use granular `--unstable-ffi` instead. Learn more at: https://docs.deno.com/runtime/manual/tools/unstable_flags ``` When no "--unstable-*" flag is provided and an unstable API is called following warning is issued before exiting: ``` Unstable API 'Deno.dlopen'. The `--unstable-ffi` flag must be provided. ``` --------- Signed-off-by: Divy Srivastava Signed-off-by: Bartek Iwańczuk Co-authored-by: Divy Srivastava Co-authored-by: Asher Gomez --- test_ffi/tests/integration_tests.rs | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) (limited to 'test_ffi/tests/integration_tests.rs') diff --git a/test_ffi/tests/integration_tests.rs b/test_ffi/tests/integration_tests.rs index a9a458d16..642fbed03 100644 --- a/test_ffi/tests/integration_tests.rs +++ b/test_ffi/tests/integration_tests.rs @@ -135,7 +135,7 @@ fn symbol_types() { let output = deno_cmd() .arg("check") - .arg("--unstable") + .arg("--unstable-ffi") .arg("--quiet") .arg("tests/ffi_types.ts") .env("NO_COLOR", "1") @@ -160,7 +160,7 @@ fn thread_safe_callback() { .arg("run") .arg("--allow-ffi") .arg("--allow-read") - .arg("--unstable") + .arg("--unstable-ffi") .arg("--quiet") .arg("tests/thread_safe_test.js") .env("NO_COLOR", "1") @@ -194,7 +194,7 @@ fn event_loop_integration() { .arg("run") .arg("--allow-ffi") .arg("--allow-read") - .arg("--unstable") + .arg("--unstable-ffi") .arg("--quiet") .arg("tests/event_loop_integration.ts") .env("NO_COLOR", "1") @@ -246,7 +246,7 @@ fn ffi_callback_errors_test() { .arg("run") .arg("--allow-ffi") .arg("--allow-read") - .arg("--unstable") + .arg("--unstable-ffi") .arg("--quiet") .arg("tests/ffi_callback_errors.ts") .env("NO_COLOR", "1") -- cgit v1.2.3