From 9eca71caa1674c31f9cc5d4e86c03f10b59e0a00 Mon Sep 17 00:00:00 2001 From: Rob Waller Date: Tue, 14 Jul 2020 19:41:05 +0100 Subject: fix(std/testing): assertThrows inheritance (#6623) --- std/testing/asserts.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'std/testing/asserts.ts') diff --git a/std/testing/asserts.ts b/std/testing/asserts.ts index b1164090d..2a1358143 100644 --- a/std/testing/asserts.ts +++ b/std/testing/asserts.ts @@ -394,7 +394,7 @@ export function assertThrows( if (e instanceof Error === false) { throw new AssertionError("A non-Error object was thrown."); } - if (ErrorClass && !(Object.getPrototypeOf(e) === ErrorClass.prototype)) { + if (ErrorClass && !(e instanceof ErrorClass)) { msg = `Expected error to be instance of "${ErrorClass.name}", but was "${ e.constructor.name }"${msg ? `: ${msg}` : "."}`; @@ -438,7 +438,7 @@ export async function assertThrowsAsync( if (e instanceof Error === false) { throw new AssertionError("A non-Error object was thrown or rejected."); } - if (ErrorClass && !(Object.getPrototypeOf(e) === ErrorClass.prototype)) { + if (ErrorClass && !(e instanceof ErrorClass)) { msg = `Expected error to be instance of "${ErrorClass.name}", but got "${ e.name }"${msg ? `: ${msg}` : "."}`; -- cgit v1.2.3