From fb08cf7005c9dc781d51c7d02ae06060e44d32a3 Mon Sep 17 00:00:00 2001 From: ecyrbe Date: Mon, 24 Feb 2020 14:35:45 +0100 Subject: Add missing node os.release() implementation (#4065) --- std/node/os.ts | 4 ++-- std/node/os_test.ts | 14 +++++++------- 2 files changed, 9 insertions(+), 9 deletions(-) (limited to 'std/node') diff --git a/std/node/os.ts b/std/node/os.ts index 39209b4b7..f34551da9 100644 --- a/std/node/os.ts +++ b/std/node/os.ts @@ -161,9 +161,9 @@ export function platform(): string { return process.platform; } -/** Not yet implemented */ +/** Returns the operating system as a string */ export function release(): string { - notImplemented(SEE_GITHUB_ISSUE); + return Deno.osRelease(); } /** Not yet implemented */ diff --git a/std/node/os_test.ts b/std/node/os_test.ts index 2ceff79a4..6ef123575 100644 --- a/std/node/os_test.ts +++ b/std/node/os_test.ts @@ -30,6 +30,13 @@ test({ } }); +test({ + name: "release is a string", + fn() { + assertEquals(typeof os.release(), "string"); + } +}); + test({ name: "getPriority(): PID must be a 32 bit integer", fn() { @@ -216,13 +223,6 @@ test({ Error, "Not implemented" ); - assertThrows( - () => { - os.release(); - }, - Error, - "Not implemented" - ); assertThrows( () => { os.setPriority(0); -- cgit v1.2.3