From f5c0188b5edf9451aca42347dd4a48708fefce23 Mon Sep 17 00:00:00 2001 From: Evan Hahn Date: Wed, 20 May 2020 09:29:05 -0500 Subject: std/node: add util.callbackify (#5415) This adds [Node's `util.callbackify`][0] to `std/node/util.ts`. I lifted most of this from the [original Node source code][1] (and [its tests][2]). I tried to make minimal modifications to the source. I made a few arbitrary decisions: - I was unable to do the function's types elegantly. I made overloads for functions that have 0 to 5 (inclusive) arguments, excluding the callback. I would love to know a better way to do this. (It seems that the folks at DefinitelyTyped [were also stumped][3], though maybe their solution is deliberate.) - There are a few edge cases that cause custom Node errors to be produced. Instead of re-implementing those errors completely, I created simplified classes. These are mostly correct but are not identical to the real Node errors. - The tests implement a possibly-arcane `TestQueue` class. I originally used a lot of inline promises but found it too repetitive. Closes [#5366][4]. [0]: https://nodejs.org/api/util.html#util_util_callbackify_original [1]: https://github.com/nodejs/node/blob/47804933012841f2dc90626bdcc161adf34569a5/lib/util.js#L183-L226 [2]: https://github.com/nodejs/node/blob/47804933012841f2dc90626bdcc161adf34569a5/test/parallel/test-util-callbackify.js [3]: https://github.com/DefinitelyTyped/DefinitelyTyped/blob/7d24857ddb07ab637dfa8c477d13352f8a8206fc/types/node/util.d.ts#L61-L84 [4]: https://github.com/denoland/deno/issues/5366 --- std/node/util.ts | 2 ++ 1 file changed, 2 insertions(+) (limited to 'std/node/util.ts') diff --git a/std/node/util.ts b/std/node/util.ts index 73cbbf823..a61dc30b2 100644 --- a/std/node/util.ts +++ b/std/node/util.ts @@ -1,3 +1,5 @@ +export { callbackify } from "./_util/_util_callbackify.ts"; + export function isArray(value: unknown): boolean { return Array.isArray(value); } -- cgit v1.2.3