From 06bd692e5c4a8f66960d3919e7087530b60c20dd Mon Sep 17 00:00:00 2001 From: Liam Murphy <43807659+Liamolucko@users.noreply.github.com> Date: Tue, 26 Jan 2021 23:34:40 +1100 Subject: fix(std/node): Stop callbacks being called twice when callback throws error (#8867) --- std/node/_fs/_fs_lstat.ts | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) (limited to 'std/node/_fs/_fs_lstat.ts') diff --git a/std/node/_fs/_fs_lstat.ts b/std/node/_fs/_fs_lstat.ts index 0b79fb665..55624cd5e 100644 --- a/std/node/_fs/_fs_lstat.ts +++ b/std/node/_fs/_fs_lstat.ts @@ -27,8 +27,7 @@ export function lstat( (typeof optionsOrCallback === "function" ? optionsOrCallback : maybeCallback) as ( - err: Error | undefined, - stat: BigIntStats | Stats, + ...args: [Error] | [null, BigIntStats | Stats] ) => void; const options = typeof optionsOrCallback === "object" ? optionsOrCallback @@ -36,9 +35,10 @@ export function lstat( if (!callback) throw new Error("No callback function supplied"); - Deno.lstat(path) - .then((stat) => callback(undefined, CFISBIS(stat, options.bigint))) - .catch((err) => callback(err, err)); + Deno.lstat(path).then( + (stat) => callback(null, CFISBIS(stat, options.bigint)), + (err) => callback(err), + ); } export function lstatSync(path: string | URL): Stats; -- cgit v1.2.3