From 6e2df8c64feb92653077a5494d2c64a9f6fd2f48 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Bartek=20Iwa=C5=84czuk?= Date: Thu, 19 Mar 2020 00:25:55 +0100 Subject: feat: Deno.test() sanitizes ops and resources (#4399) This PR brings assertOps and assertResources sanitizers to Deno.test() API. assertOps checks that test doesn't leak async ops, ie. there are no unresolved promises originating from Deno APIs. Enabled by default, can be disabled using Deno.TestDefinition.disableOpSanitizer. assertResources checks that test doesn't leak resources, ie. all resources used in test are closed. For example; if a file is opened during a test case it must be explicitly closed before test case finishes. It's most useful for asynchronous generators. Enabled by default, can be disabled using Deno.TestDefinition.disableResourceSanitizer. We've used those sanitizers in internal runtime tests and it proved very useful in surfacing incorrect tests which resulted in interference between the tests. All tests have been sanitized. Closes #4208 --- std/node/_fs/_fs_dir_test.ts | 18 ++++++++++++------ 1 file changed, 12 insertions(+), 6 deletions(-) (limited to 'std/node/_fs/_fs_dir_test.ts') diff --git a/std/node/_fs/_fs_dir_test.ts b/std/node/_fs/_fs_dir_test.ts index aefa85854..3b8c5b341 100644 --- a/std/node/_fs/_fs_dir_test.ts +++ b/std/node/_fs/_fs_dir_test.ts @@ -71,8 +71,10 @@ test({ name: "Async read returns one file at a time", async fn() { const testDir: string = Deno.makeTempDirSync(); - Deno.createSync(testDir + "/foo.txt"); - Deno.createSync(testDir + "/bar.txt"); + const f1 = Deno.createSync(testDir + "/foo.txt"); + f1.close(); + const f2 = Deno.createSync(testDir + "/bar.txt"); + f2.close(); try { let secondCallback = false; @@ -108,8 +110,10 @@ test({ name: "Sync read returns one file at a time", fn() { const testDir: string = Deno.makeTempDirSync(); - Deno.createSync(testDir + "/foo.txt"); - Deno.createSync(testDir + "/bar.txt"); + const f1 = Deno.createSync(testDir + "/foo.txt"); + f1.close(); + const f2 = Deno.createSync(testDir + "/bar.txt"); + f2.close(); try { const dir: Dir = new Dir(testDir); @@ -135,8 +139,10 @@ test({ name: "Async iteration over existing directory", async fn() { const testDir: string = Deno.makeTempDirSync(); - Deno.createSync(testDir + "/foo.txt"); - Deno.createSync(testDir + "/bar.txt"); + const f1 = Deno.createSync(testDir + "/foo.txt"); + f1.close(); + const f2 = Deno.createSync(testDir + "/bar.txt"); + f2.close(); try { const dir: Dir = new Dir(testDir); -- cgit v1.2.3