From f32c31a0eba90b6b1f711a2d5dfe182157d3ecb5 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Bartek=20Iwa=C5=84czuk?= <biwanczuk@gmail.com>
Date: Tue, 28 Jan 2020 03:13:17 +0100
Subject: dx: descriptive permission errors (#3808)
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Before:
```
▶ target/debug/deno https://deno.land/std/examples/echo_server.ts
error: Uncaught PermissionDenied: run again with the --allow-net flag
► $deno$/dispatch_json.ts:40:11
    at DenoError ($deno$/errors.ts:20:5)
    at unwrapResponse ($deno$/dispatch_json.ts:40:11)
    at sendSync ($deno$/dispatch_json.ts:67:10)
    at listen ($deno$/net.ts:170:15)
    at https://deno.land/std/examples/echo_server.ts:4:23
```

```
▶ target/debug/deno --allow-read=/usr https://deno.land/std/examples/cat.ts /etc/passwd
error: Uncaught PermissionDenied: run again with the --allow-read flag
► $deno$/dispatch_json.ts:40:11
    at DenoError ($deno$/errors.ts:20:5)
    at unwrapResponse ($deno$/dispatch_json.ts:40:11)
    at sendAsync ($deno$/dispatch_json.ts:91:10)
```

After:
```
▶ target/debug/deno https://deno.land/std/examples/echo_server.ts
error: Uncaught PermissionDenied: network access to "0.0.0.0:8080", run again with the --allow-net flag
► $deno$/dispatch_json.ts:40:11
    at DenoError ($deno$/errors.ts:20:5)
    at unwrapResponse ($deno$/dispatch_json.ts:40:11)
    at sendSync ($deno$/dispatch_json.ts:67:10)
    at listen ($deno$/net.ts:170:15)
    at https://deno.land/std/examples/echo_server.ts:4:23
```

```
▶ target/debug/deno --allow-read=/usr https://deno.land/std/examples/cat.ts /etc/passwd
error: Uncaught PermissionDenied: read access to "/etc/passwd", run again with the --allow-read flag
► $deno$/dispatch_json.ts:40:11
    at DenoError ($deno$/errors.ts:20:5)
    at unwrapResponse ($deno$/dispatch_json.ts:40:11)
    at sendAsync ($deno$/dispatch_json.ts:91:10)
```
---
 std/fs/empty_dir_test.ts | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

(limited to 'std/fs/empty_dir_test.ts')

diff --git a/std/fs/empty_dir_test.ts b/std/fs/empty_dir_test.ts
index 77e98c0ce..b9145767e 100644
--- a/std/fs/empty_dir_test.ts
+++ b/std/fs/empty_dir_test.ts
@@ -2,6 +2,7 @@
 import { test } from "../testing/mod.ts";
 import {
   assertEquals,
+  assertStrContains,
   assertThrows,
   assertThrowsAsync
 } from "../testing/asserts.ts";
@@ -227,7 +228,7 @@ test(async function emptyDirPermission(): Promise<void> {
 
       const output = await Deno.readAll(stdout);
 
-      assertEquals(new TextDecoder().decode(output), s.output);
+      assertStrContains(new TextDecoder().decode(output), s.output);
     }
   } catch (err) {
     await Deno.remove(testfolder, { recursive: true });
-- 
cgit v1.2.3