From ea6c9f2f365698e8120177bb7a1344e83f859180 Mon Sep 17 00:00:00 2001 From: Ryan Dahl Date: Thu, 3 Jan 2019 22:11:01 -0500 Subject: Revert "use byte array instead of string for code fetch (#1307)" (#1455) This reverts commit e976b3e0414dc768624b77e431ee7f55b03b76a4. There is nothing technically wrong with this commit, but it's adding complexity to a big refactor (native ES modules #975). Since it's not necessary and simply a philosophical preference, I will revert for now and try to bring it back later. --- src/msg.fbs | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) (limited to 'src/msg.fbs') diff --git a/src/msg.fbs b/src/msg.fbs index b576d0f23..f68b40c1a 100644 --- a/src/msg.fbs +++ b/src/msg.fbs @@ -160,16 +160,18 @@ table CodeFetchRes { module_name: string; filename: string; media_type: MediaType; - source_code: [ubyte]; - output_code: [ubyte]; // Non-empty only if cached. - source_map: [ubyte]; // Non-empty only if cached. + // TODO These should be [ubyte]. + // See: https://github.com/denoland/deno/issues/1113 + source_code: string; + output_code: string; // Non-empty only if cached. + source_map: string; // Non-empty only if cached. } table CodeCache { filename: string; - source_code: [ubyte]; - output_code: [ubyte]; - source_map: [ubyte]; + source_code: string; + output_code: string; + source_map: string; } table Chdir { -- cgit v1.2.3