From 24b0e91d8096f84a114f662e3eb42c83d0d3878d Mon Sep 17 00:00:00 2001 From: Bert Belder Date: Mon, 9 Jul 2018 03:35:34 +0200 Subject: Move buffers between V8 and native * send()/recv() now operate on TypedArrays rather than ArrayBuffers. * Remove a copy (through ArrayBuffer.slice()) from the send path. * Remove a copy (through v8::ArrayBuffer::New()) from the return path. * After moving a buffer from JS to native, the ArrayBuffer object and it's views are made inaccessible ('neutered'). * `struct deno_buf` now holds two [ptr, length] tuples, one for the actual memory allocation, and one for the logical data contained therein. This is necessary because flatbuffers fills it's buffer bottom-up, so the serialized blob doesn't start at beginning of the buffer, but somewhere in the middle. --- src/deno.h | 13 +++++++++++-- 1 file changed, 11 insertions(+), 2 deletions(-) (limited to 'src/deno.h') diff --git a/src/deno.h b/src/deno.h index fd2b4766a..ab214ab03 100644 --- a/src/deno.h +++ b/src/deno.h @@ -3,6 +3,7 @@ #ifndef DENO_H_ #define DENO_H_ #include +#include // Neither Rust nor Go support calling directly into C++ functions, therefore // the public interface to libdeno is done in C. #ifdef __cplusplus @@ -11,8 +12,10 @@ extern "C" { // Data that gets transmitted. typedef struct { - const char* data; - size_t len; + uint8_t* alloc_ptr; // Start of memory allocation (returned from `malloc()`). + size_t alloc_len; // Length of the memory allocation. + uint8_t* data_ptr; // Start of logical contents (within the allocation). + size_t data_len; // Length of logical contents. } deno_buf; struct deno_s; @@ -37,11 +40,17 @@ int deno_execute(Deno* d, const char* js_filename, const char* js_source); // Routes message to the javascript callback set with deno.recv(). A false // return value indicates error. Check deno_last_exception() for exception text. // 0 = fail, 1 = success +// After calling deno_send(), the caller no longer owns `buf` and must not use +// it; deno_send() is responsible for releasing it's memory. +// TODO(piscisaureus) In C++ and/or Rust, use a smart pointer or similar to +// enforce this rule. int deno_send(Deno* d, deno_buf buf); // Call this inside a deno_recv_cb to respond synchronously to messages. // If this is not called during the life time of a deno_recv_cb callback // the deno.send() call in javascript will return null. +// After calling deno_set_response(), the caller no longer owns `buf` and must +// not access it; deno_set_response() is responsible for releasing it's memory. void deno_set_response(Deno* d, deno_buf buf); const char* deno_last_exception(Deno* d); -- cgit v1.2.3