From b1b418b81a13ede548273665e83c1bc5a97dffcd Mon Sep 17 00:00:00 2001 From: Ben Noordhuis Date: Mon, 19 Sep 2022 10:25:03 +0200 Subject: chore: fix clippy warnings (#15944) Stop allowing clippy::derive-partial-eq-without-eq and fix warnings about deriving PartialEq without also deriving Eq. In one case I removed the PartialEq because it a) wasn't necessary, and b) sketchy because it was comparing floating point numbers. IMO, that's a good argument for enforcing the lint rule, because it would most likely have been caught during review if it had been enabled. --- serde_v8/tests/de.rs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'serde_v8/tests') diff --git a/serde_v8/tests/de.rs b/serde_v8/tests/de.rs index 5ae104036..c29b35760 100644 --- a/serde_v8/tests/de.rs +++ b/serde_v8/tests/de.rs @@ -319,7 +319,7 @@ detest!( defail!(defail_struct, MathOp, "123", |e| e == Err(Error::ExpectedObject)); -#[derive(PartialEq, Debug, Deserialize)] +#[derive(Eq, PartialEq, Debug, Deserialize)] pub struct SomeThing { pub a: String, #[serde(default)] @@ -339,7 +339,7 @@ detest!(de_bstr, ByteString, "'hello'", "hello".into()); defail!(defail_bstr, ByteString, "'👋bye'", |e| e == Err(Error::ExpectedLatin1)); -#[derive(PartialEq, Debug, Deserialize)] +#[derive(Eq, PartialEq, Debug, Deserialize)] pub struct StructWithBytes { #[serde(with = "serde_bytes")] a: Vec, -- cgit v1.2.3