From 4258e06f87f33e1cbf434f5040fc8dfabe254c12 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Bartek=20Iwa=C5=84czuk?= Date: Wed, 21 Dec 2022 14:24:39 +0100 Subject: fix(permissions): add information about import() API request (#17149) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This commit changes permission prompt to show that "import()" API is requesting permissions. Given "dynamic_import.js" like so: ``` import("https://deno.land/std@0.170.0/version.ts"); ``` Before: ``` deno run dynamic_import.js ⚠️ ┌ Deno requests net access to "deno.land". ├ Run again with --allow-net to bypass this prompt. └ Allow? [y/n] (y = yes, allow; n = no, deny) > ``` After: ``` deno run dynamic_import.js ⚠️ ┌ Deno requests net access to "deno.land". ├ Requested by `import()` API ├ Run again with --allow-net to bypass this prompt. └ Allow? [y/n] (y = yes, allow; n = no, deny) > ``` --- runtime/permissions/mod.rs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'runtime') diff --git a/runtime/permissions/mod.rs b/runtime/permissions/mod.rs index 23c9917cd..5b2af0e0f 100644 --- a/runtime/permissions/mod.rs +++ b/runtime/permissions/mod.rs @@ -1601,7 +1601,7 @@ impl Permissions { ) -> Result<(), AnyError> { match specifier.scheme() { "file" => match specifier.to_file_path() { - Ok(path) => self.read.check(&path, None), + Ok(path) => self.read.check(&path, Some("import()")), Err(_) => Err(uri_error(format!( "Invalid file path.\n Specifier: {}", specifier @@ -1609,7 +1609,7 @@ impl Permissions { }, "data" => Ok(()), "blob" => Ok(()), - _ => self.net.check_url(specifier, None), + _ => self.net.check_url(specifier, Some("import()")), } } } -- cgit v1.2.3