From 98403691d100fec0804c86d8b89d0d3f8da68354 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ricardo=20Iv=C3=A1n=20Vieitez=20Parra?= <3857362+corrideat@users.noreply.github.com> Date: Mon, 31 Jul 2023 23:22:07 +0200 Subject: fix: call setIsTrusted for generated events (MessageEvent) (#19919) This addresses issue #19918. ## Issue description Event messages have the wrong isTrusted value when they are not triggered by user interaction, which differs from the browser. In particular, all MessageEvents created by Deno have isTrusted set to false, even though it should be true. This is my first ever contribution to Deno, so I might be missing something. --- runtime/js/11_workers.js | 3 +++ runtime/js/99_main.js | 2 ++ 2 files changed, 5 insertions(+) (limited to 'runtime/js') diff --git a/runtime/js/11_workers.js b/runtime/js/11_workers.js index e04690005..f5548d8d1 100644 --- a/runtime/js/11_workers.js +++ b/runtime/js/11_workers.js @@ -22,6 +22,7 @@ import { ErrorEvent, EventTarget, MessageEvent, + setIsTrusted, } from "ext:deno_web/02_event.js"; import { deserializeJsMessageData, @@ -187,6 +188,7 @@ class Worker extends EventTarget { cancelable: false, data: err, }); + setIsTrusted(event, true); this.dispatchEvent(event); return; } @@ -198,6 +200,7 @@ class Worker extends EventTarget { (t) => ObjectPrototypeIsPrototypeOf(MessagePortPrototype, t), ), }); + setIsTrusted(event, true); this.dispatchEvent(event); } }; diff --git a/runtime/js/99_main.js b/runtime/js/99_main.js index 483ca9012..dc6839646 100644 --- a/runtime/js/99_main.js +++ b/runtime/js/99_main.js @@ -154,6 +154,7 @@ async function pollForMessages() { ObjectPrototypeIsPrototypeOf(messagePort.MessagePortPrototype, t), ), }); + event.setIsTrusted(msgEvent, true); try { globalDispatchEvent(msgEvent); @@ -167,6 +168,7 @@ async function pollForMessages() { error: e, }); + event.setIsTrusted(errorEvent, true); globalDispatchEvent(errorEvent); if (!errorEvent.defaultPrevented) { throw e; -- cgit v1.2.3