From 50eaeabefb83042686e271687979c2a0c40cc7e6 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Bartek=20Iwa=C5=84czuk?= <biwanczuk@gmail.com>
Date: Wed, 24 Jan 2024 16:35:47 +0100
Subject: feat: Change deprecation warning formatting (#22080)

Removes weird "frame like" characters and simplifies the output:

```
warning: Use of deprecated "Deno.isatty()" API. This API will be removed in Deno 2.

Stack trace:
  at file:///Users/ib/dev/deno/foo.js:2:8

hint: Use `stdStream.isTerminal()` instead.

warning: Use of deprecated "Deno.isatty()" API. This API will be removed in Deno 2.

Stack trace:
  at file:///Users/ib/dev/deno/foo.js:7:8

hint: Use `stdStream.isTerminal()` instead.

```

https://github.com/denoland/deno/assets/13602871/7a6e24bf-44ec-4dbf-ac96-2af1db9f2ab9
---
 runtime/js/99_main.js | 47 +++++++++++++++--------------------------------
 1 file changed, 15 insertions(+), 32 deletions(-)

(limited to 'runtime/js')

diff --git a/runtime/js/99_main.js b/runtime/js/99_main.js
index fe3dab58b..0cfcafbd2 100644
--- a/runtime/js/99_main.js
+++ b/runtime/js/99_main.js
@@ -143,49 +143,32 @@ function warnOnDeprecatedApi(apiName, stack, ...suggestions) {
 
   ALREADY_WARNED_DEPRECATED.add(apiName + stack);
   console.error(
-    "%cWarning",
-    "color: yellow; font-weight: bold;",
-  );
-  console.error(
-    `%c\u251c Use of deprecated "${apiName}" API.`,
-    "color: yellow;",
-  );
-  console.error("%c\u2502", "color: yellow;");
-  console.error(
-    "%c\u251c This API will be removed in Deno 2.0. Make sure to upgrade to a stable API before then.",
+    `%cwarning: %cUse of deprecated "${apiName}" API. This API will be removed in Deno 2.`,
     "color: yellow;",
+    "font-weight: bold;",
   );
 
+  console.error();
+  if (stackLines.length > 0) {
+    console.error("Stack trace:");
+    for (let i = 0; i < stackLines.length; i++) {
+      console.error(`  ${StringPrototypeTrim(stackLines[i])}`);
+    }
+    console.error();
+  }
+
   for (let i = 0; i < suggestions.length; i++) {
     const suggestion = suggestions[i];
-    console.error("%c\u2502", "color: yellow;");
     console.error(
-      `%c\u251c Suggestion: ${suggestion}`,
-      "color: yellow;",
+      `%chint: ${suggestion}`,
+      "font-weight: bold;",
     );
   }
   if (isFromRemoteDependency) {
-    console.error("%c\u2502", "color: yellow;");
     console.error(
-      `%c\u251c Suggestion: It appears this API is used by a remote dependency.`,
-      "color: yellow;",
+      `%chint: It appears this API is used by a remote dependency. Try upgrading to the latest version of that dependency.`,
+      "font-weight: bold;",
     );
-    console.error(
-      "%c\u2502             Try upgrading to the latest version of that dependency.",
-      "color: yellow;",
-    );
-  }
-  if (stackLines.length > 0) {
-    console.error("%c\u2502", "color: yellow;");
-    console.error("%c\u2514 Stack trace:", "color: yellow;");
-    for (let i = 0; i < stackLines.length; i++) {
-      console.error(
-        `%c  ${i == stackLines.length - 1 ? "\u2514" : "\u251c"}\u2500 ${
-          StringPrototypeTrim(stackLines[i])
-        }`,
-        "color: yellow;",
-      );
-    }
   }
   console.error();
 }
-- 
cgit v1.2.3