From b40086fd7da3729d1d59b312c89ee57747fc66a9 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Bartek=20Iwa=C5=84czuk?= Date: Sat, 4 Mar 2023 22:31:38 -0400 Subject: refactor(core): include_js_files! 'dir' option doesn't change specifiers (#18019) This commit changes "include_js_files!" macro from "deno_core" in a way that "dir" option doesn't cause specifiers to be rewritten to include it. Example: ``` include_js_files! { dir "js", "hello.js", } ``` The above definition required embedders to use: `import ... from "internal:/js/hello.js"`. But with this change, the "js" directory in which the files are stored is an implementation detail, which for embedders results in: `import ... from "internal:/hello.js"`. The directory the files are stored in, is an implementation detail and in some cases might result in a significant size difference for the snapshot. As an example, in "deno_node" extension, we store the source code in "polyfills" directory; which resulted in each specifier to look like "internal:deno_node/polyfills/", but with this change it's "internal:deno_node/". Given that "deno_node" has over 100 files, many of them having several import specifiers to the same extension, this change removes 10 characters from each import specifier. --- runtime/js/90_deno_ns.js | 34 +++++++++++++++++----------------- 1 file changed, 17 insertions(+), 17 deletions(-) (limited to 'runtime/js/90_deno_ns.js') diff --git a/runtime/js/90_deno_ns.js b/runtime/js/90_deno_ns.js index 8ad285e42..6bb3d10d6 100644 --- a/runtime/js/90_deno_ns.js +++ b/runtime/js/90_deno_ns.js @@ -10,25 +10,25 @@ import * as net from "internal:deno_net/01_net.js"; import * as tls from "internal:deno_net/02_tls.js"; import * as http from "internal:deno_http/01_http.js"; import * as flash from "internal:deno_flash/01_http.js"; -import * as build from "internal:runtime/js/01_build.js"; -import * as errors from "internal:runtime/js/01_errors.js"; -import * as version from "internal:runtime/js/01_version.ts"; -import * as permissions from "internal:runtime/js/10_permissions.js"; +import * as build from "internal:runtime/01_build.js"; +import * as errors from "internal:runtime/01_errors.js"; +import * as version from "internal:runtime/01_version.ts"; +import * as permissions from "internal:runtime/10_permissions.js"; import * as io from "internal:deno_io/12_io.js"; -import * as buffer from "internal:runtime/js/13_buffer.js"; -import * as fs from "internal:runtime/js/30_fs.js"; -import * as os from "internal:runtime/js/30_os.js"; -import * as diagnostics from "internal:runtime/js/40_diagnostics.js"; -import * as files from "internal:runtime/js/40_files.js"; -import * as fsEvents from "internal:runtime/js/40_fs_events.js"; -import * as process from "internal:runtime/js/40_process.js"; -import * as readFile from "internal:runtime/js/40_read_file.js"; -import * as signals from "internal:runtime/js/40_signals.js"; -import * as tty from "internal:runtime/js/40_tty.js"; -import * as writeFile from "internal:runtime/js/40_write_file.js"; -import * as spawn from "internal:runtime/js/40_spawn.js"; +import * as buffer from "internal:runtime/13_buffer.js"; +import * as fs from "internal:runtime/30_fs.js"; +import * as os from "internal:runtime/30_os.js"; +import * as diagnostics from "internal:runtime/40_diagnostics.js"; +import * as files from "internal:runtime/40_files.js"; +import * as fsEvents from "internal:runtime/40_fs_events.js"; +import * as process from "internal:runtime/40_process.js"; +import * as readFile from "internal:runtime/40_read_file.js"; +import * as signals from "internal:runtime/40_signals.js"; +import * as tty from "internal:runtime/40_tty.js"; +import * as writeFile from "internal:runtime/40_write_file.js"; +import * as spawn from "internal:runtime/40_spawn.js"; // TODO(bartlomieju): this is funky we have two `http` imports -import * as httpRuntime from "internal:runtime/js/40_http.js"; +import * as httpRuntime from "internal:runtime/40_http.js"; const denoNs = { metrics: core.metrics, -- cgit v1.2.3