From 2d1208556ad09844407c484b1e23887e3ade97c7 Mon Sep 17 00:00:00 2001 From: Steven Guerrero Date: Thu, 14 Jan 2021 14:18:51 -0500 Subject: fix: don't swallow customInspect exceptions (#9095) --- runtime/js/02_console.js | 18 +++--------------- 1 file changed, 3 insertions(+), 15 deletions(-) (limited to 'runtime/js/02_console.js') diff --git a/runtime/js/02_console.js b/runtime/js/02_console.js index c6c53977b..595bf5006 100644 --- a/runtime/js/02_console.js +++ b/runtime/js/02_console.js @@ -190,11 +190,7 @@ function inspectFunction(value, _ctx) { if (customInspect in value && typeof value[customInspect] === "function") { - try { - return String(value[customInspect]()); - } catch { - // pass - } + return String(value[customInspect]()); } // Might be Function/AsyncFunction/GeneratorFunction/AsyncGeneratorFunction let cstrName = Object.getPrototypeOf(value)?.constructor?.name; @@ -865,11 +861,7 @@ inspectOptions, ) { if (customInspect in value && typeof value[customInspect] === "function") { - try { - return String(value[customInspect]()); - } catch { - // pass - } + return String(value[customInspect]()); } // This non-unique symbol is used to support op_crates, ie. // in op_crates/web we don't want to depend on unique "Deno.customInspect" @@ -880,11 +872,7 @@ nonUniqueCustomInspect in value && typeof value[nonUniqueCustomInspect] === "function" ) { - try { - return String(value[nonUniqueCustomInspect]()); - } catch { - // pass - } + return String(value[nonUniqueCustomInspect]()); } if (value instanceof Error) { return String(value.stack); -- cgit v1.2.3