From ad3c494b46c97f0cf91098b7ec2afa576ea7a3dd Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Bartek=20Iwa=C5=84czuk?= Date: Mon, 26 Jun 2023 13:54:10 +0200 Subject: =?UTF-8?q?Revert=20"Reland=20"refactor(core):=20cleanup=20feature?= =?UTF-8?q?=20flags=20for=20js=20source=20i=E2=80=A6=20(#19611)?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit …nclusion" (#19519)" This reverts commit 28a4f3d0f5383695b1d49ccdc8b0f799a715b2c2. This change causes failures when used outside Deno repo: ``` ============================================================ Deno has panicked. This is a bug in Deno. Please report this at https://github.com/denoland/deno/issues/new. If you can reliably reproduce this panic, include the reproduction steps and re-run with the RUST_BACKTRACE=1 env var set and include the backtrace in your report. Platform: linux x86_64 Version: 1.34.3+b37b286 Args: ["/opt/hostedtoolcache/deno/0.0.0-b37b286f7fa68d5656f7c180f6127bdc38cf2cf5/x64/deno", "test", "--doc", "--unstable", "--allow-all", "--coverage=./cov"] thread 'main' panicked at 'called `Result::unwrap()` on an `Err` value: Failed to read "/home/runner/work/deno/deno/core/00_primordials.js" Caused by: No such file or directory (os error 2)', core/runtime/jsruntime.rs:699:8 note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace ``` --- runtime/js.rs | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) (limited to 'runtime/js.rs') diff --git a/runtime/js.rs b/runtime/js.rs index 099ca0c0e..def2724ce 100644 --- a/runtime/js.rs +++ b/runtime/js.rs @@ -14,8 +14,9 @@ pub fn deno_isolate_init() -> Snapshot { Snapshot::Static(RUNTIME_SNAPSHOT) } -/// Depends on LTO to be excluded from production binaries if unused. +#[cfg(not(feature = "include_js_files_for_snapshotting"))] pub static SOURCE_CODE_FOR_99_MAIN_JS: &str = include_str!("js/99_main.js"); +#[cfg(feature = "include_js_files_for_snapshotting")] pub static PATH_FOR_99_MAIN_JS: &str = concat!(env!("CARGO_MANIFEST_DIR"), "/js/99_main.js"); -- cgit v1.2.3